Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netcore Preview3 #69

Closed
wants to merge 11 commits into from
Closed

Netcore Preview3 #69

wants to merge 11 commits into from

Conversation

cloudRoutine
Copy link
Member

@cloudRoutine cloudRoutine commented Dec 6, 2016 •
edited

setup netcore builds for fslex, fsyacc, & fslexyacc.runtime for preview3 with new fsproj format

@cloudRoutine
Copy link
Member Author

@enricosada could you help me get the CI working on this?
Weren't you working on cli extensibility tools for fslex and fsyacc? It'll only be a small amount of setup on top of this if you still want to do that.

@cloudRoutine
# This is a combination of 3 commits.
0d12de5 
# The first commit's message is:

update build.fsx

# The commit message fsprojects#2 will be skipped:

# change sdk dir update travis config

# The commit message fsprojects#3 will be skipped:

# paket tweak
@enricosada
Copy link
Contributor

@cloudRoutine about cli tool, i think is going to be a FsSrGen item like before now with new msbuild based preview3, so the dotnet fssrgen is not that useful.

@enricosada
Copy link
Contributor

@cloudRoutine what's the issue with ci? travis fake failure?

@cloudRoutine
Copy link
Member Author

@enricosada yup Travis thwarts me once again.

There were a bunch of commits of me trying to get Travis working but I squashed them 😉

@ncave
Copy link

ncave commented Jul 13, 2017

@cloudRoutine @enricosada Is it just CI holding this back, or does it need to be updated to netstandard 2.0? How about a tooling version (dotnet-fslexyacc)? Just asking if I can help with something.

@enricosada
Copy link
Contributor

enricosada commented Jul 13, 2017 •
edited

@ncave atm is just missing some ❤️ i'll try to move it forward, need just a refresh of fake script

no, leave netstandard2.0 aside. is preview (bleeding edge) and should not be used (IHMO) unless really needed for api surface, until is rtm.

about dotnet fssrgen ihmo is not that useful anymore.
was good in project.json era, but now is better to maintain only the msbuild task, and remove the dotnet fssrgen

this for multiple reasons:

  1. msbuild task is easier to use becase can be now (with msbuild15) bundled target+.dll in a single package, who will add it just reference it as packagereference/paketref
  2. incremental build
  3. faster, no need to spawn process

the 1 was the annoying part with old sdk, but is not really smooth in new one

so i'll try to refresh it, but if someone want to do that. better, because is a bit low in my list atm

@ncave
Copy link

ncave commented Jul 13, 2017

@enricosada Thanks.
To clarify, I was asking not about dotnet-fssrgen (that's already available for netcore1.0/1.1 and very useful), but dotnet-fslexyacc. But I get your point about the task being better, thanks.

@dsyme
Copy link
Contributor

dsyme commented Apr 10, 2019

Closing this old PR

@dsyme dsyme closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cloudRoutine @enricosada @ncave @dsyme