New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build and tests (absolutely minimal yet) #86
Conversation
edd2432
to
283d869
Compare
Paket is a monster. Changes it tries to apply to projects are unmaintainable. FAKE has a lot of dependencies, but does not declare them in its NuGet package.
Thanks for all your hard work!
It is important to re-enable his as these form the majority of tests for the project
I believe FAKE has no dependencies since they are all bundled into the "tools" folder in the FAKE package.
Yes, this is expected - if you ask paket to update everything it updates everything. The right thing to do is pin all packages to existing versions in |
@@ -152,7 +152,7 @@ Target "All" DoNothing | |||
"Clean" | |||
==> "AssemblyInfo" | |||
==> "Build" | |||
=?> ("RunOldFsYaccTests", isWindows) | |||
// =?> ("RunOldFsYaccTests", isWindows) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WHy did this need to be disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from disabling the tests everything looks great
Closing this old PR |
Looks like projects would benefit from a bigger rework. I'll open an issue for that separately.
I had to disable RunOldFsYaccTests for now
Changes it tries to apply to projects are unmaintainable. FAKE has a lot of dependencies, some are quite intimate, like FSharp.Compiler.Service, but pretends it has none.
Paket is a monster. When I tried to
packet update
just the FSharp.Compiler.Service package, it created a few thousand line changeset to projects. Curiously, that broke compile, so more exact dependency declarations are required. And such changes are hardly maintainable. Beats me hands down!Closes #84