Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referencing portable library #1645

Closed
JonCanning opened this issue Apr 26, 2016 · 6 comments
Closed

Referencing portable library #1645

JonCanning opened this issue Apr 26, 2016 · 6 comments

Comments

@JonCanning
Copy link
Contributor

JonCanning commented Apr 26, 2016

Description

Using Auth0 libraries which only has portable targets

nuspec

Reference is not added to project

Repro steps

paket add nuget Auth0.AuthenticationApi project MyProject

Expected behavior

Reference is added

Actual behavior

Warning shown in console

Package Auth0.AuthenticationApi contains libraries, but not for the selected TargetFramework net452 in project

Reference is not added

Known workarounds

Rename folders in lib to net45

@forki forki added the bug label Apr 26, 2016
@inosik
Copy link
Contributor

inosik commented Apr 26, 2016

The portable45-net45+win8+wpa81 directory doesn't look right to me. As of NuGet docs, there is no portable45, only portable.

Their project file has the Profile111 TargetFrameworkProfile, which should translate to portable-net45+win8+wpa81.

NuGet can't install this package either, BTW.

@forki
Copy link
Member

forki commented Apr 26, 2016

Yeah I guess that's the issue.
On Apr 26, 2016 12:56 PM, "Ilja Nosik" notifications@github.com wrote:

The portable45-net45+win8+wpa81 directory doesn't look right to me. As of NuGet
docs https://docs.nuget.org/create/targetframeworks, there is no
portable45, only portable.

Their project file has the Profile111 TargetFrameworkProfile, which
should translate to portable-net45+win8+wpa81.

NuGet can't install this package either, BTW.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1645 (comment)

@JonCanning
Copy link
Contributor Author

I'll raise it with the Auth0 devs

@inosik
Copy link
Contributor

inosik commented Apr 27, 2016

Paket still translates the incorrect moniker into this:

<Choose>
  <When Condition="($(TargetFrameworkIdentifier) == 'WindowsPhoneApp') Or ($(TargetFrameworkIdentifier) == '.NETCore') Or ($(TargetFrameworkProfile) == 'Profile32')">
    <ItemGroup>
      <Reference Include="Auth0.AuthenticationApi">
        <HintPath>..\packages\Auth0.AuthenticationApi\lib\portable45-net45+win8+wpa81\Auth0.AuthenticationApi.dll</HintPath>
        <Private>True</Private>
        <Paket>True</Paket>
      </Reference>
    </ItemGroup>
  </When>
</Choose>

Which is wrong, obviously. Should we do something about that?

@forki
Copy link
Member

forki commented Apr 27, 2016

I guess it will just go away when the package is fixed ;-)

@enricosada
Copy link
Collaborator

Closing, fixed in upstream package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants