New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG?: update with any of the --keep-?? flags doesn't honour content:none in paket.dependencies #1701

Closed
pms1969 opened this Issue May 23, 2016 · 9 comments

Comments

Projects
None yet
3 participants
@pms1969
Contributor

pms1969 commented May 23, 2016

Description

Not sure if it's a bug, expected behaviour or something else. But if I do a paket update --keep-major when I have specified content:none for a package in paket.dependencies, I end up with the contents being copied to the project folder and the csproj being updated. Running paket update again removes the files as expected.

Repro steps

Please provide the steps required to reproduce the problem

  1. create an empty solution with an bare class library project
  2. paket init
  3. paket add nuget bootstrap project <projectname>
  4. note the addition of the content files to the project (folders contents, fonts, scripts)
  5. edit paket.dependencies and place content:none next to bootstrap
  6. paket update
  7. note the contents have been removed from the project
  8. paket update --keep-major
  9. note the contents are back.

Expected behavior

at step 9, the project should not contain the contents of the bootstrap package

Actual behavior

It does

Known workarounds

update the package.references file to include content:none for the package as well

Related information

  • Operating system: Windows 7
  • Branch : paket version 2.65.2.0
  • .NET Runtime, CoreCLR or Mono Version: 4.5
  • Performance information, links to performance testing scripts
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 23, 2016

Member

can you please send me the project after step 7? I can't reproduce

Member

forki commented May 23, 2016

can you please send me the project after step 7? I can't reproduce

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 May 23, 2016

Contributor

I'll have to do it on my way home @forki . Corporate policy dictates. :-s Should be about an hour and a half. Direct to your email ok?

Contributor

pms1969 commented May 23, 2016

I'll have to do it on my way home @forki . Corporate policy dictates. :-s Should be about an hour and a half. Direct to your email ok?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 23, 2016

Member

Yes that would be great. Or put it here as a zip. Both works for me. Thanks
On May 23, 2016 16:35, "Paul Saunders" notifications@github.com wrote:

I'll have to do it on my way home @forki https://github.com/forki .
Corporate policy dictates. :-s Should be about an hour and a half. Direct
to your email ok?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1701 (comment)

Member

forki commented May 23, 2016

Yes that would be great. Or put it here as a zip. Both works for me. Thanks
On May 23, 2016 16:35, "Paul Saunders" notifications@github.com wrote:

I'll have to do it on my way home @forki https://github.com/forki .
Corporate policy dictates. :-s Should be about an hour and a half. Direct
to your email ok?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1701 (comment)

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 May 23, 2016

Contributor

ok, can add as zip, hadn't spotted that.
TestPaket.zip

Contributor

pms1969 commented May 23, 2016

ok, can add as zip, hadn't spotted that.
TestPaket.zip

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 23, 2016

Member

Ok I can reproduce with that. thanks

Member

forki commented May 23, 2016

Ok I can reproduce with that. thanks

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 23, 2016

Member

image

should be flying again

Member

forki commented May 23, 2016

image

should be flying again

@forki forki closed this May 23, 2016

forki added a commit that referenced this issue May 23, 2016

@isaacabraham

This comment has been minimized.

Show comment
Hide comment
@isaacabraham

isaacabraham May 23, 2016

Contributor

lol. genius.

Contributor

isaacabraham commented May 23, 2016

lol. genius.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 23, 2016

Member

Puhh at least someone understood. ;-)

Member

forki commented May 23, 2016

Puhh at least someone understood. ;-)

@pms1969

This comment has been minimized.

Show comment
Hide comment
@pms1969

pms1969 May 24, 2016

Contributor

Excellent work. Thanks. And yes, I think it was understood all round. ;-)

Contributor

pms1969 commented May 24, 2016

Excellent work. Thanks. And yes, I think it was understood all round. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment