New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket doesn't reference libs for UWP apps #2001

Closed
punker76 opened this Issue Nov 3, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@punker76
Contributor

punker76 commented Nov 3, 2016

Description

If I want to reference a UWP (Universal Windows Platfrom) library to an UWP app with Paket it installs/reference only the .NETFramework ones.

Paket version: 3.26.1

Repro steps

  1. Create a Windows Universal Platform app on Win10 with VS 2015 and win sdk 10.0.10240 or higher
  2. Add the dependencies for the library at the necessary Paket files
source https://nuget.org/api/v2

nuget MahApps.Metro.IconPacks

and this reference file

MahApps.Metro.IconPacks framework: >= net46
  1. call paket install

Here is the git repository with a repro sample.

Expected behavior

It would be nice if Paket has some mechanism to add the dlls also for the UAP target platform.

<When Condition="$(TargetPlatformIdentifier) == 'UAP' And $(TargetPlatformVersion) == '10.0.14393.0'">
  <ItemGroup>
    <Reference Include="MahApps.Metro.IconPacks.Core">
      <HintPath>..\packages\MahApps.Metro.IconPacks\lib\uap10.0\MahApps.Metro.IconPacks.Core.dll</HintPath>
      <Private>True</Private>
      <Paket>True</Paket>
    </Reference>
    <Reference Include="MahApps.Metro.IconPacks">
      <HintPath>..\packages\MahApps.Metro.IconPacks\lib\uap10.0\MahApps.Metro.IconPacks.dll</HintPath>
      <Private>True</Private>
      <Paket>True</Paket>
    </Reference>
  </ItemGroup>
</When>

Actual behavior

Paket references only the .NET framwork part

<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.6' Or $(TargetFrameworkVersion) == 'v4.6.1' Or $(TargetFrameworkVersion) == 'v4.6.2' Or $(TargetFrameworkVersion) == 'v4.6.3')">
  <ItemGroup>
    <Reference Include="MahApps.Metro.IconPacks">
      <HintPath>..\packages\MahApps.Metro.IconPacks\lib\net46\MahApps.Metro.IconPacks.dll</HintPath>
      <Private>True</Private>
      <Paket>True</Paket>
    </Reference>
  </ItemGroup>
</When>

I think that Paket could look at these properties of the project file

    <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
    <TargetPlatformVersion>10.0.14393.0</TargetPlatformVersion>
    <TargetPlatformMinVersion>10.0.10240.0</TargetPlatformMinVersion>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment