Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslashes not escaped after #3071 #3093

Closed
sliepie opened this issue Feb 27, 2018 · 7 comments
Closed

Backslashes not escaped after #3071 #3093

sliepie opened this issue Feb 27, 2018 · 7 comments

Comments

@sliepie
Copy link
Contributor

sliepie commented Feb 27, 2018

Description

Today I upgraded from Fake 5-beta018 to beta020 because of the broken intellisense in VSCode. (fsprojects/FAKE#1744).
With this change the forward slashes in intellisense.fsx are replaced with single back slashes.

Repro steps

Please provide the steps required to reproduce the problem

  1. Upgrade Fake 5 from beta018 to beta020

  2. Delete [script_name.fsx].lock file

  3. Call fake.cmd, such that a restore is triggert

  4. Open directory in Ionide

repo

Expected behavior

Expected output:

#if !FAKE
#r "C:/Users/jarno/.nuget/packages/fake.core.xml/5.0.0-beta018/lib/net46/Fake.Core.Xml.dll"

Actual behavior

Actual output:

#if !FAKE
#r "C:\Users\jarno\.nuget\packages\fake.core.xml\5.0.0-beta020\lib\net46\Fake.Core.Xml.dll"

Known workarounds

Possible workarounds are:

  1. Replacing the \ with /
  2. Escape the \ with a extra \

Example:

#if !FAKE
#r "C:\\Users\\jarno\\.nuget\\packages\\fake.core.xml\\5.0.0-beta020\\lib\\net46\\Fake.Core.Xml.dll"
@matthid
Copy link
Member

matthid commented Feb 27, 2018

Ah sorry... you fix something on one side and something else breaks on the other side :/

@forki
Copy link
Member

forki commented Feb 28, 2018 via email

@matthid
Copy link
Member

matthid commented Feb 28, 2018

Yes most likely load script generation is still broken

@forki
Copy link
Member

forki commented Feb 28, 2018 via email

@matthid
Copy link
Member

matthid commented Feb 28, 2018

I added the fix to #3090

@forki
Copy link
Member

forki commented Feb 28, 2018

that one gets huge ;-)

@matthid
Copy link
Member

matthid commented Feb 28, 2018

+45 −18 is still kind of review-able ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants