Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Load Scripts fails with BadImageFormatException on Microsoft.TestPlatform.TestHost #3097

Closed
ChrSteinert opened this issue Feb 28, 2018 · 4 comments · Fixed by #3098

Comments

@ChrSteinert
Copy link
Contributor

ChrSteinert commented Feb 28, 2018

Description

When the package Microsoft.TestPlatform.TestHost is a dependency in paket.dependencies file and it is tried to create a load script for that dependency paket fails with a BadImageFormatException.

Repro steps

See a repro repo here: https://github.com/ChrSteinert/Paket-3097
Do a paket install && paket generate-load-scripts do trigger the bug.

Expected behavior

Paket ignores native dll files.

Actual behavior

Paket tries on multiple occasions to load .dll files of a package. Some are guarded by try…with, but some are not. Load Script generation hits the latter one and breaks if it tries to load native dlls from (for instance) the Microsoft.TestPlatform.TestHost package.

Known workarounds

Do not generate Load Scripts for those packages.

@forki
Copy link
Member

forki commented Feb 28, 2018

any chance to send a fix? I think @isaacabraham hit it as well

@isaacabraham
Copy link
Contributor

Hmmm. I vaguely remember something about this but can't remember when or where. Getting old I guess...

@ChrSteinert
Copy link
Contributor Author

It was hitting you here: fsprojects/FSharp.CloudAgent#19 @isaacabraham 😄

@ChrSteinert
Copy link
Contributor Author

Let me see if I can understand what is going on quickly and not just bash a try…with in there as well…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants