New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for only using nuget v3 api #1205

Merged
merged 6 commits into from Nov 11, 2015

Conversation

Projects
None yet
2 participants
@xavierzwirtz
Contributor

xavierzwirtz commented Nov 9, 2015

Can be used by setting source https://api.nuget.org/v3/index.json in paket.dependencies

Adds a reference to NuGet.Versioning so that we can reuse there parsing logic for the new version range syntax.

I wrote this so that paket could be used against nuget servers that do not support the v2 api. The v3 api, while still crazy in places, is much easier to implement.

@xavierzwirtz

This comment has been minimized.

Show comment
Hide comment
@xavierzwirtz

xavierzwirtz Nov 10, 2015

Owner

According to http://stackoverflow.com/a/27993704/4358412 a multipart-form request must end with a final new line, after the boundary.

Owner

xavierzwirtz commented on 2414c63 Nov 10, 2015

According to http://stackoverflow.com/a/27993704/4358412 a multipart-form request must end with a final new line, after the boundary.

Show outdated Hide outdated paket.dependencies
@@ -3,6 +3,7 @@ source https://nuget.org/api/v2
nuget Newtonsoft.Json redirects: on
nuget Argu
nuget FSharp.Core redirects: on
nuget NuGet.Versioning

This comment has been minimized.

@forki

forki Nov 11, 2015

Member

why do we need this?

@forki

forki Nov 11, 2015

Member

why do we need this?

This comment has been minimized.

@forki

forki Nov 11, 2015

Member

ah "Adds a reference to NuGet.Versioning so that we can reuse there parsing logic for the new version range syntax."

I don't think that's a good idea. we already have parse logic and I think we should take that dependency. We're much faster with fixes if this little parse code is under our control.

@forki

forki Nov 11, 2015

Member

ah "Adds a reference to NuGet.Versioning so that we can reuse there parsing logic for the new version range syntax."

I don't think that's a good idea. we already have parse logic and I think we should take that dependency. We're much faster with fixes if this little parse code is under our control.

Show outdated Hide outdated paket.lock
@@ -4,6 +4,68 @@ NUGET
Argu (1.1.2)
FSharp.Core (4.0.0.1) - redirects: on
Newtonsoft.Json (7.0.1) - redirects: on
NuGet.Versioning (3.2.0)
System.Diagnostics.Debug (>= 4.0.10-beta-23109)

This comment has been minimized.

@forki

forki Nov 11, 2015

Member

Sorry I don't think it's a good idea to take this dependency ;-)

@forki

forki Nov 11, 2015

Member

Sorry I don't think it's a good idea to take this dependency ;-)

@xavierzwirtz

This comment has been minimized.

Show comment
Hide comment
@xavierzwirtz

xavierzwirtz Nov 11, 2015

Contributor

I removed the dependency on NuGet.Versioning, it looked like the dependency range syntax had changed radically in v3, but it hasn't changed at all. The v3 api is just handing out valid, but odd, version ranges.

Contributor

xavierzwirtz commented Nov 11, 2015

I removed the dependency on NuGet.Versioning, it looked like the dependency range syntax had changed radically in v3, but it hasn't changed at all. The v3 api is just handing out valid, but odd, version ranges.

@xavierzwirtz

This comment has been minimized.

Show comment
Hide comment
@xavierzwirtz

xavierzwirtz Nov 11, 2015

Contributor

One thing I didn't do, which could be a target for a future pr, is call the v3 apis whenever a v2 api is handed in. That might speed up the typical dependency resolution.

Contributor

xavierzwirtz commented Nov 11, 2015

One thing I didn't do, which could be a target for a future pr, is call the v3 apis whenever a v2 api is handed in. That might speed up the typical dependency resolution.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki commented on paket.dependencies in f6e92c3 Nov 11, 2015

❤️

@forki forki merged commit ac40c17 into fsprojects:master Nov 11, 2015

1 check failed

continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
@xavierzwirtz

This comment has been minimized.

Show comment
Hide comment
@xavierzwirtz

xavierzwirtz Nov 11, 2015

Contributor

Wooooo!

Contributor

xavierzwirtz commented Nov 11, 2015

Wooooo!

@forki

This comment has been minimized.

Show comment
Hide comment
@forki
Member

forki commented Nov 11, 2015

hurray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment