Support for only using nuget v3 api #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,7 @@ source https://nuget.org/api/v2 | |||
| nuget Newtonsoft.Json redirects: on | |||
| nuget Argu | |||
| nuget FSharp.Core redirects: on | |||
| nuget NuGet.Versioning | |||
There was a problem hiding this comment.
ah "Adds a reference to NuGet.Versioning so that we can reuse there parsing logic for the new version range syntax."
I don't think that's a good idea. we already have parse logic and I think we should take that dependency. We're much faster with fixes if this little parse code is under our control.
|
I removed the dependency on |
|
One thing I didn't do, which could be a target for a future pr, is call the v3 apis whenever a v2 api is handed in. That might speed up the typical dependency resolution. |
|
Wooooo! |
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used by setting
source https://api.nuget.org/v3/index.jsonin paket.dependenciesAdds a reference to NuGet.Versioning so that we can reuse there parsing logic for the new version range syntax.
I wrote this so that paket could be used against nuget servers that do not support the v2 api. The v3 api, while still crazy in places, is much easier to implement.