-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recognize .netstandard framework #1605
Conversation
I don't know if this is related, but I tried a
giving
I don't know if it is driver error, e.g. incorrect feeds, or that the myget feeds are not coughing up the lists of available versions, or the same as the bug being fixed here. |
seems to work. |
@forki Thanks! silly me :) |
I think we will make that more robust. Nobody really knows how these new
|
I removed the [WIP] prefix - I think we can merge it and fix whatever comes next |
I added couple of other things to this, but Paket 2.61 now works with .NETSTANDARD. At least with Kestrel in https://github.com/CumpsD/kestrel-classic/pull/1 |
Cool thanks! |
would love to hear if it works for you. |
Will see in next days but hopefully it does 👍 |
@@ -222,6 +225,7 @@ module FrameworkDetection = | |||
| "dnx451" -> Some(DNX FrameworkVersion.V4_5_1) | |||
| "dnxcore50" | "netplatform50" | "netcore50" | "aspnetcore50" | "aspnet50" | "dotnet" -> Some(DNXCore FrameworkVersion.V5_0) | |||
| v when v.StartsWith "dotnet" -> Some(DNXCore FrameworkVersion.V5_0) | |||
| v when v.StartsWith "netstandard" -> Some(DotNetStandard "1.5") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this gloss over the differences between "netstandard1.0", "netstandard1.3" and "netstandard1.5" and does it mater? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I extended it to understand all published standard versions.
On Apr 18, 2016 17:45, "Don Syme" notifications@github.com wrote:
In src/Paket.Core/FrameworkHandling.fs
#1605 (comment):@@ -222,6 +225,7 @@ module FrameworkDetection =
| "dnx451" -> Some(DNX FrameworkVersion.V4_5_1)
| "dnxcore50" | "netplatform50" | "netcore50" | "aspnetcore50" | "aspnet50" | "dotnet" -> Some(DNXCore FrameworkVersion.V5_0)
| v when v.StartsWith "dotnet" -> Some(DNXCore FrameworkVersion.V5_0)
| v when v.StartsWith "netstandard" -> Some(DotNetStandard "1.5")
Does this gloss over the differences between "netstandard1.0",
"netstandard1.3" and "netstandard1.5" and does it mater? thanks—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/pull/1605/files/299e7083879c167e788152e39d40c59eae01d7e6#r60082429
checked my use case - works fine. The remaining concern is indeed the unofficial prelease source feeds, which are required to pull down latest packages. Eventually the packages are to be published to the official feed, but till then it would be good to somehow guide users to work with prerelease feeds - not sure how to do this though |
what concern do you mean? Adding endpoint to deps file should be enough, right? |
Yes its enough but just as you stated above it's not obvious at once which feeds should be added |
Apparently, .netstandard is going to replace all
dnxcore
monikers as described here: https://github.com/dotnet/corefx/blob/master/Documentation/architecture/net-platform-standard.md#deprecated-monikers