Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognize .netstandard framework #1605

Merged
merged 1 commit into from
Apr 17, 2016
Merged

Conversation

theimowski
Copy link
Member

Apparently, .netstandard is going to replace all dnxcore monikers as described here: https://github.com/dotnet/corefx/blob/master/Documentation/architecture/net-platform-standard.md#deprecated-monikers

@dsyme
Copy link
Contributor

dsyme commented Apr 13, 2016

I don't know if this is related, but I tried a paket update on this and it didn't resolve:


source https://dotnet.myget.org/F/dotnet-core/api/v3/
source https://api.nuget.org/v3/index.json
source https://www.nuget.org/api/v2/

nuget NETStandard.Library 1.5.0-rc3-24013

giving

C:\misc\repro-54>.paket\paket.exe update
Paket version 2.60.2.0
Resolving packages for group Main:
 - NETStandard.Library is pinned to 1.5.0-rc3-24013
Paket failed with:
        Could not find versions for package NETStandard.Library on any of ["http
s://dotnet.myget.org/F/dotnet-core/api/v3";
 "http://api.nuget.org/v3/index.json"; "https://www.nuget.org/api/v2"].

I don't know if it is driver error, e.g. incorrect feeds, or that the myget feeds are not coughing up the lists of available versions, or the same as the bug being fixed here.

@forki
Copy link
Member

forki commented Apr 13, 2016

source https://www.myget.org/F/dotnet-core/api/v3/index.json

brings:

image

@forki
Copy link
Member

forki commented Apr 13, 2016

source https://www.myget.org/F/dotnet-core/api/v3/index.json
source https://api.nuget.org/v3/index.json
source https://www.nuget.org/api/v2/

nuget NETStandard.Library 1.5.0-rc3-24013-00

seems to work.

@dsyme
Copy link
Contributor

dsyme commented Apr 13, 2016

@forki Thanks! silly me :)

@forki
Copy link
Member

forki commented Apr 13, 2016

I think we will make that more robust. Nobody really knows how these new
endpoints are really meant to be used. (or at least I don't know).
On Apr 13, 2016 10:13 PM, "Don Syme" notifications@github.com wrote:

@forki https://github.com/forki Thanks! silly me :)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1605 (comment)

@theimowski theimowski changed the title [WIP] recognize .netstandard framework recognize .netstandard framework Apr 16, 2016
@theimowski
Copy link
Member Author

I removed the [WIP] prefix - I think we can merge it and fix whatever comes next

@forki forki merged commit 299e708 into fsprojects:master Apr 17, 2016
@forki
Copy link
Member

forki commented Apr 17, 2016

I added couple of other things to this, but Paket 2.61 now works with .NETSTANDARD. At least with Kestrel in https://github.com/CumpsD/kestrel-classic/pull/1

@theimowski
Copy link
Member Author

Cool thanks!

@theimowski theimowski deleted the netstandard branch April 17, 2016 14:00
@forki
Copy link
Member

forki commented Apr 17, 2016

would love to hear if it works for you.

@theimowski
Copy link
Member Author

Will see in next days but hopefully it does 👍

@@ -222,6 +225,7 @@ module FrameworkDetection =
| "dnx451" -> Some(DNX FrameworkVersion.V4_5_1)
| "dnxcore50" | "netplatform50" | "netcore50" | "aspnetcore50" | "aspnet50" | "dotnet" -> Some(DNXCore FrameworkVersion.V5_0)
| v when v.StartsWith "dotnet" -> Some(DNXCore FrameworkVersion.V5_0)
| v when v.StartsWith "netstandard" -> Some(DotNetStandard "1.5")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this gloss over the differences between "netstandard1.0", "netstandard1.3" and "netstandard1.5" and does it mater? thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I extended it to understand all published standard versions.
On Apr 18, 2016 17:45, "Don Syme" notifications@github.com wrote:

In src/Paket.Core/FrameworkHandling.fs
#1605 (comment):

@@ -222,6 +225,7 @@ module FrameworkDetection =
| "dnx451" -> Some(DNX FrameworkVersion.V4_5_1)
| "dnxcore50" | "netplatform50" | "netcore50" | "aspnetcore50" | "aspnet50" | "dotnet" -> Some(DNXCore FrameworkVersion.V5_0)
| v when v.StartsWith "dotnet" -> Some(DNXCore FrameworkVersion.V5_0)

  •            | v when v.StartsWith "netstandard" -> Some(DotNetStandard "1.5")
    

Does this gloss over the differences between "netstandard1.0",
"netstandard1.3" and "netstandard1.5" and does it mater? thanks


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/pull/1605/files/299e7083879c167e788152e39d40c59eae01d7e6#r60082429

@theimowski
Copy link
Member Author

checked my use case - works fine. The remaining concern is indeed the unofficial prelease source feeds, which are required to pull down latest packages. Eventually the packages are to be published to the official feed, but till then it would be good to somehow guide users to work with prerelease feeds - not sure how to do this though

@forki
Copy link
Member

forki commented Apr 19, 2016

what concern do you mean? Adding endpoint to deps file should be enough, right?

@theimowski
Copy link
Member Author

Yes its enough but just as you stated above it's not obvious at once which feeds should be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants