Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken condition in WhenNode #2022

Merged
merged 1 commit into from Nov 17, 2016
Merged

Fix broken condition in WhenNode #2022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Paket.Core/ProjectFile.fs
View file
Open in desktop
Expand Up @@ -828,9 +828,10 @@ module ProjectFile =
let containsProperties = ref false
targetsFileConditions
|> List.map (fun (condition,(propertyNames,propertyGroup)) ->
let finalCondition = if condition = "" || condition.Length > 3000 || condition = "$(TargetFrameworkIdentifier) == 'true'" then "1 == 1" else condition
let whenNode =
createNode "When" project
|> addAttribute "Condition" condition
|> addAttribute "Condition" finalCondition
if not <| Set.isEmpty propertyNames then
whenNode.AppendChild(propertyGroup) |> ignore
containsProperties := true
Expand Down