New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #2227] import .props/.targets better #2234

Merged
merged 2 commits into from Apr 12, 2017

Conversation

Projects
None yet
2 participants
@0x53A
Contributor

0x53A commented Apr 11, 2017

fixes #2227

  • differentiate between global targets/props, and framework specific targets/props
  • fw-specifc targets/props continue to be imported in the the middle with a condition (no change to before)
  • global props are imported at the top of the file (same as nuget does)
  • global targets are imported at the end of the file (same as nuget)

The reason is that many props depend on being imported at the top, so do that for the files where it is actually possible.

@0x53A 0x53A changed the title from [Wip] import .props/.targets better to [fix #2227] import .props/.targets better Apr 11, 2017

0x53A added some commits Apr 11, 2017

import .props/.targets better
fixes #2227

* differentiate between global targets/props, and framework specific targets/props
* fw-specifc targets/props continue to be imported in the the middle with a condition (no change to before)
* global props are imported at the top of the file (same as nuget does)
* global targets are imported at the end of the file (same as nuget)

The reason is that many props depend on being imported at the top, so do that for the files where it is actually possible.
@0x53A

This comment has been minimized.

Show comment
Hide comment
@0x53A

0x53A Apr 11, 2017

Contributor

Looks like travis is flakey? Close - reopen should trigger a rebuild ...

Contributor

0x53A commented Apr 11, 2017

Looks like travis is flakey? Close - reopen should trigger a rebuild ...

@0x53A 0x53A closed this Apr 11, 2017

@0x53A 0x53A reopened this Apr 11, 2017

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 12, 2017

Member

Awesome! Let's see how it works in practice ;-)

Member

forki commented Apr 12, 2017

Awesome! Let's see how it works in practice ;-)

@forki forki merged commit 2039fee into fsprojects:master Apr 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@0x53A 0x53A deleted the 0x53A:fix-2227 branch Apr 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment