[fix #2227] import .props/.targets better #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x53A
changed the title
fixes fsprojects#2227 * differentiate between global targets/props, and framework specific targets/props * fw-specifc targets/props continue to be imported in the the middle with a condition (no change to before) * global props are imported at the top of the file (same as nuget does) * global targets are imported at the end of the file (same as nuget) The reason is that many props depend on being imported at the top, so do that for the files where it is actually possible.
|
Looks like travis is flakey? Close - reopen should trigger a rebuild ... |
|
Awesome! Let's see how it works in practice ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2227
The reason is that many props depend on being imported at the top, so do that for the files where it is actually possible.