-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fix dotnetcore #2252
Closed
Closed
WIP: Fix dotnetcore #2252
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ba2c5e7
fix whitespace
matthid 270537a
revert some latest changes and start from scratch
matthid d862bcf
Merge branch 'master' into fix_dotnetcore
matthid cc44e8f
dotnetcore support: Step1 - Introduce UnparsedPackageFile to make the…
matthid e9ec445
fixup for step 1 + add scanf implementation for simplification.
matthid c229b3f
implement generic sscanf functionality.
matthid 66e5cfd
step 2 - remove runtime support and rewrite InstallModel
matthid 165a689
fix 'native' handling in lib/native folder.
matthid 00c4f57
cleanup
matthid 761e95d
ok some tests check the global build directory
matthid 7f3fd5b
simplify code and fix tests
matthid 1663d8b
fix tests
matthid 77796ca
fix of the quickfix
matthid 34ff91e
Merge branch 'master' into fix_dotnetcore
matthid d17487d
ignore casing again...
matthid 924c1de
Merge branch 'fix_dotnetcore' of github.com:matthid/Paket into fix_do…
matthid 6845ebc
cleanup global targets detection and remove comment which is no longe…
matthid a9d3a61
fixup of previous merge...
matthid File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be some code-path to "simplify" the generated project file. However it seems like it was never actually used.
After removing
runtime
this seems to work again (and breaks some tests).Should we get rid of this simplification (as it was never used) or should I update the tests?