proper encoding "+" in package download url #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbearzhu
changed the title
|
Its probably fine as it is but I'd really like to see unit tests for this. Do you feel like you could add some? Tbh we should have added them right away... |
|
since this is better than what we have and actually fixes a bug I'm willing to merge it now. But please send a nother PR with a unit test. Thx |
|
Thanks for quick merge. I tried to add some test before sending the pull request, didn't find existing tests for either NuGetV2.fs or SemVer.fs. The SemVerTests.cs seems is for the bootstrapper only. Mind pointing me to the right place/way? I only use F# occasionally, not very good at doing big refactoring jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2261 properly. Encode "+" only in base url not query string. And encode when the download link is just fetched.
See https://dotnetfiddle.net/7RwLPU for what the encodeURL does.
Also there is another bug in
SemVer.Parsethat parse the prerelease incorrectly when metadata is used. e.g.2.0.54674-master+d277eafwould havemaster+as prerelease, but it should bemaster.