make xamarin stuff work with netstandard (#2396). #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
reviewed
Jun 10, 2017
| @@ -513,7 +513,7 @@ module FrameworkDetection = | |||
| | "netcore10" -> Some (DotNetCore DotNetCoreVersion.V1_0) | |||
| | "netcore11" -> Some (DotNetCore DotNetCoreVersion.V1_1) | |||
| | "netcore20" -> Some (DotNetCore DotNetCoreVersion.V2_0) | |||
| | v when v.StartsWith "netstandard" -> Some(DotNetStandard DotNetStandardVersion.V1_6) | |||
| //| v when v.StartsWith "netstandard" -> Some(DotNetStandard DotNetStandardVersion.V1_6) | |||
There was a problem hiding this comment.
not sure we want to do that - it was already wrong for the "netstandard" case and it is basically wrong when new ones are added
|
Instead of commenting please remove it completely if you think it's wrong
Am 10.06.2017 18:14 schrieb "Matthias Dittrich" <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In src/Paket.Core/Versioning/FrameworkHandling.fs
<#2411 (comment)>:
> @@ -513,7 +513,7 @@ module FrameworkDetection =
| "netcore10" -> Some (DotNetCore DotNetCoreVersion.V1_0)
| "netcore11" -> Some (DotNetCore DotNetCoreVersion.V1_1)
| "netcore20" -> Some (DotNetCore DotNetCoreVersion.V2_0)
- | v when v.StartsWith "netstandard" -> Some(DotNetStandard DotNetStandardVersion.V1_6)
+ //| v when v.StartsWith "netstandard" -> Some(DotNetStandard DotNetStandardVersion.V1_6)
not sure I want to do that it was already wrong for the "netstandard" case
and is basically wrong when new ones are added
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2411 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADgNHjtkyKBbpCVGyWXyNwJdP9fze8Bks5sCsDigaJpZM4N2JYO>
.
|
|
Ok, Obviously the cleanup crew wasn't there jet ;) |
matthid
changed the title
matthid
commented
Jun 10, 2017
| <Paket>True</Paket> | ||
| </Reference> | ||
| </ItemGroup> | ||
| </When> |
There was a problem hiding this comment.
Not exactly sure what paket is doing there, but I guess it's correct...
matthid
commented
Jun 10, 2017
| <HintPath>..\..\packages\razor4\System.AppContext\ref\netstandard1.6\System.AppContext.xml</HintPath> | ||
| <Private>False</Private> | ||
| <Paket>True</Paket> | ||
| </Reference> |
There was a problem hiding this comment.
This is another bug I'm fixing another time #2390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2396.