New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for #913 Paket.pack: add support for nuget dependencies conditional on target framework #2428

Merged
merged 5 commits into from Jun 18, 2017

Conversation

Projects
None yet
3 participants
@bhugot
Contributor

bhugot commented Jun 16, 2017

Hi, this is a proposal for #913

it's going to fix a bit of #2394 too

the template should be 'type file'

and the syntax is the following

type file
id My.Thing
authors Bob McBob
description
    A longer description
    on two lines.
version
    1.0
dependencies 
    framework: net45
        FSharp.Core 4.3.1
        My.OtherThing
    framework: netstandard11
        FSharp.Core 4.3.1  
@bhugot

This comment has been minimized.

Show comment
Hide comment
@bhugot

bhugot Jun 18, 2017

Contributor

@forki Hi is it possible to review this one it's really a needed feature

Contributor

bhugot commented Jun 18, 2017

@forki Hi is it possible to review this one it's really a needed feature

@forki

This looks very good. Only couple of minor nitpicks.

Show outdated Hide outdated src/Paket.Core/Packaging/NupkgWriter.fs Outdated
Show outdated Hide outdated src/Paket.Core/Packaging/NupkgWriter.fs Outdated
Show outdated Hide outdated src/Paket.Core/Packaging/NupkgWriter.fs Outdated
let addDependency (templateFile : TemplateFile) (dependency : PackageName * VersionRequirement) =
let addDependency (templateFile : TemplateFile) (dependency : PackageName * VersionRequirement * FrameworkIdentifier option) =
match templateFile with
| CompleteTemplate(core, opt) ->

This comment has been minimized.

@forki

forki Jun 18, 2017

Member

Same here. Please get rid of firstOf3

@forki

forki Jun 18, 2017

Member

Same here. Please get rid of firstOf3

Show outdated Hide outdated src/Paket.Core/PaketConfigFiles/TemplateFile.fs Outdated
Show outdated Hide outdated src/Paket.Core/Versioning/FrameworkHandling.fs Outdated
@bhugot

This comment has been minimized.

Show comment
Hide comment
@bhugot

bhugot Jun 18, 2017

Contributor

Hope the change are good for you, my first time with F# so I don't know all the good way to do.

Contributor

bhugot commented Jun 18, 2017

Hope the change are good for you, my first time with F# so I don't know all the good way to do.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 18, 2017

Member
Member

forki commented Jun 18, 2017

@bhugot

This comment has been minimized.

Show comment
Hide comment
@bhugot

bhugot Jun 18, 2017

Contributor

Added documentation.

Contributor

bhugot commented Jun 18, 2017

Added documentation.

@forki forki merged commit 6bdcf80 into fsprojects:master Jun 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 18, 2017

Member

thanks a lot! released in 5.1

Member

forki commented Jun 18, 2017

thanks a lot! released in 5.1

@bhugot

This comment has been minimized.

Show comment
Hide comment
@bhugot

bhugot Jun 18, 2017

Contributor

No problems it s helping my team too

Contributor

bhugot commented Jun 18, 2017

No problems it s helping my team too

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Sep 3, 2017

Member

Obviously I'm a bit late but shouldn't we be able to calculate the correct groups from the framework restrictions ourself? All we would need is the list of frameworks the package contains binaries for. Rest could be figured out by paket itself.

Member

matthid commented Sep 3, 2017

Obviously I'm a bit late but shouldn't we be able to calculate the correct groups from the framework restrictions ourself? All we would need is the list of frameworks the package contains binaries for. Rest could be figured out by paket itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment