Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Really Ready] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core #2528
referenced this pull request
Jul 16, 2017
I don't think that is a good idea.
When you do dotnet new and paket convert, the resulting project will be broken (and still compiling, so the user doesn't notice it).
I would say let's wait for a response on that issue, maybe there is a compilerflag to disable the magic core reference?
Great, locally I have the same three
It is picking up the global.json from the paket root folder. Probably a good idea to hardcode the cli version.
I need to test if it actually works (probably doesn't, I know myself =) ), and a few unit tests would also be nice, but from my side this is mostly finished.
As it stands, it adds FSharp.Core on
What do you think?
changed the title from
[wip] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core
[Readz] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core
Aug 13, 2017
Ready from my side.
CI errors seem unrelated, but please verify.
I've rebased it on master, which wiped the CI history, so here is a link to the previous CI result: https://ci.appveyor.com/project/SteffenForkmann/paket/build/0.0.1.9005
Maybe we can add long-path support for the test suite on appveyor (via App.Config). We don't really care about too long paths there. As the appveyor is green on master and our only check right now I think we need it to be green here as well. Or we wait for #2584?
Would be interesting to see WHAT is not cached. We had some problems with the bootstrapper in the past (where dotnet was calling the bootstrapper in magic mode).
This is when this error is actually reproducible.