Only overwrite NuGet metadata cache when needed, cleanup and exception handling #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
reviewed
Jan 18, 2018
| let cacheFile, oldFiles = getCacheFiles NuGetPackageCache.CurrentCacheVersion nugetURL packageName version | ||
| for f in oldFiles do | ||
| File.Delete f | ||
| let cacheFile = getCacheFiles force NuGetPackageCache.CurrentCacheVersion nugetURL packageName version | ||
| let get() = | ||
| async { | ||
| let! result = get() | ||
| match result with | ||
| | ODataSearchResult.Match result -> | ||
| File.WriteAllText(cacheFile.FullName,JsonConvert.SerializeObject(result)) |
There was a problem hiding this comment.
I assume this line now needs to go
|
Awesome. Keep them coming ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up NuGet metadata cache access based on production experience:
1/ with explicit "force", do not re/query and overwrite the metadata cache twice
2/ stale cache file cleanup should not be performed on every single read -- doing this only on "force" seems like a good idea, there is "paket clear-cache" in case more "forceful" solution is needed
3/ do not overwrite cached metadata on each access with "force", if the content already equals -- the read and comparison is faster and does not cause file-access violations