paket init: Default framework restriction #4228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the default framework restriction in the paket.dependencies file when running paket init to be �uto-detect, and adds a newline at the end of the file.
|
@ChrSteinert from my subjective experience, leaving the line totally out of the paket.dependencies gives me the best experience, and advanced users can "pin" it, if they don't like the behaviour. I think having it omitted doesn't impact the .fsproj, causes no churn in terms of version control of those files, I assume it may make the paket install take a bit longer. My suggestion unless we get better feedback would be to remove the line from the template / |
|
Huh – I was not aware, that omitting it is an option.
I found the default being a good pointer to „you can configure this that way“, without necessarily ready the documentation.
What do you think about adding a framework restriction as a comment, like many other default config files do?
…________________________________
Von: Gauthier Segay ***@***.***>
Gesendet: Monday, September 25, 2023 5:15:09 PM
An: fsprojects/Paket ***@***.***>
Cc: Christian Steinert ***@***.***>; Mention ***@***.***>
Betreff: Re: [fsprojects/Paket] paket init: Default framework restriction (PR #4228)
@ChrSteinert<https://github.com/ChrSteinert> from my subjective experience, leaving the line totally out of the paket.dependencies gives me the best experience, and advanced users can "pin" it, if they don't like the behaviour.
I think having it omitted doesn't impact the .fsproj, causes no churn in terms of version control of those files, I assume it may make the paket install take a bit longer.
My suggestion unless we get better feedback would be to remove the line from the template / paket init.
—
Reply to this email directly, view it on GitHub<#4228 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACLJHRJDGLKGQJHVGNCH5OLX4GNX3ANCNFSM6AAAAAA5F4A4QY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Did I just miss it, or is the (top level/group level) framework restriction not even mentioned in the docs? |
|
Never mind… I just cant read… |
Removes the global framework restriction from the initially created `paket.dependencies` file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #4186 , changes the default framework restriction in the paket.dependencies file when running paket init to be `auto-detect, and adds a newline at the end of the file.
While it is obviously maintainers choice to take or leave this, I also quite often "stumble" over the
net5default restriction.I would personally might pick something like the latest LTS, but
auto-detectis the least … "getting in the way of the user".Any advice/optinion is appreciated!