Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing properties to OpenApiException #222

Merged
merged 2 commits into from
May 27, 2023

Conversation

xperiandri
Copy link
Contributor

  • Headers
  • Content

Content is a crucial property to expose

@jkone27
Copy link
Contributor

jkone27 commented Apr 24, 2023

i think this file maybe shouldnt be committed ? (to use whatever is available instead of specific version?)

Requested SDK version: 7.0.203
global.json file: D:\a\SwaggerProvider\SwaggerProvider\global.json

@xperiandri xperiandri force-pushed the master branch 6 times, most recently from b202c76 to 70ba180 Compare May 26, 2023 14:21
@xperiandri
Copy link
Contributor Author

@jkone27 Fake will fail then if .NET 7 SDK present on a device

@sergey-tihon sergey-tihon merged commit 6421a67 into fsprojects:master May 27, 2023
3 checks passed
@sergey-tihon
Copy link
Member

Thanks, released as v2.0.0-theta-001

@abelbraaksma
Copy link
Member

Thanks for this! Ultimately, I would really like to be able to expose all endpoints as Result<_, _>, which appears most idiomatic, but this is a good workaround for the time being.

@sergey-tihon would you be interested in an extra parameter on the OpenApiProvider constructor that allows this to be exposed through Result? I'll create a tracking issue and a PR for that. Might be a nice feature to have in v2.0? Or is it too late to add to theta?

@sergey-tihon
Copy link
Member

@sergey-tihon would you be interested in an extra parameter on the OpenApiProvider constructor that allows this to be exposed through Result? I'll create a tracking issue and a PR for that. Might be a nice feature to have in v2.0? Or is it too late to add to theta?

@abelbraaksma, go for it if you think it will be useful for you. I am more than happy to merge it and release it to NuGet when it will be ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants