Use Visual Studio Community Toolkit to access common services, fixes #44 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for hacking on this! |
|
Great! There's no rush. And thank you for this awesome extension, @deviousasti. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some experiments to resolve #44 and thought I might as well make a PR out of it.
This adds Visual Studio Community Toolkit as dependency.
See also: https://www.vsixcookbook.com/
It might simplify stuff in the long run, for now it does decouple the common services from the package. In effect the command handler does not depend on the package or wait for it.
FantomasServiceis now wrapped as MEF component, so it also no longer depends on the package to be loaded and later disposed.With this the extension works in any editor with F# content type, so I can just open a folder of .fsx scripts and get formatting.