Formatting error with MultilineBlockBracketsOnSameColumn

[knocte]

Issue created from fantomas-online

Code

namespace GeeTower.Tests.EndToEnd

module WatcherTests =

    let CanRevokeAnIllegalCommitmentTx () =
        let lndAddress = obj()

        let config = { 
            GeeTower.Backend.Configuration.GetTestingConfig (lndAddress.ToString())
            with 
                BitcoinRpcUser = "btc"
        }

        ()

Error

Fantomas was able to format the code but the result appears to be invalid F# code.
Please open an issue.

Formatted result:

namespace GeeTower.Tests.EndToEnd

module WatcherTests =

    let CanRevokeAnIllegalCommitmentTx () =
        let lndAddress = obj ()

        let config =
            { GeeTower.Backend.Configuration.GetTestingConfig(
                lndAddress.ToString()
            ) with
                BitcoinRpcUser = "btc"
            }

        ()

Extra information

• The formatted result breaks by code.
• The formatted result gives compiler warnings.
• [maybe] I or my company would be willing to help fix this.

Options

Fantomas Master at 01/23/2021 17:11:48 - 6d75fff

    { config with
                MaxLineLength = 80
                MultilineBlockBracketsOnSameColumn = true }

_{Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?}

[nojaf]

I believe this is also a bug when MultiLineLambdaClosingNewline = false.
I'm guessing

fantomas/src/Fantomas/CodePrinter.fs

Line 2764 in 6d75fff

+> genExpr astContext e

Could use an atCurrentColumnIndent if the existing record expression is multiline (GeeTower.Backend.Configu...).

[knocte]

I believe this is also a bug when MultiLineLambdaClosingNewline = false.

Oh you're right, sorry!

[knocte]

@nojaf what should be the expected results here?

[nojaf]

To make it valid I believe it would be:

let config =
    { GeeTower.Backend.Configuration.GetTestingConfig(
        lndAddress.ToString()
      ) with
        BitcoinRpcUser = "btc"
    }

[knocte]

To make it valid I believe it would be:

Are you sure? Remember this bug only happens with MultilineBlockBracketsOnSameColumn=true. Therefore, I was thinking that to respect this setting, the snippet could be something like this:

let config =
    {
        GeeTower.Backend.Configuration.GetTestingConfig(
            lndAddress.ToString()
        ) with
            BitcoinRpcUser = "btc"
    }

Does that make sense?

[nojaf]

I don't think that would match the GR style anymore then. Could you raise it in the GR style repository as well?

[knocte]

G-Research/fsharp-formatting-conventions#17