Currying a pair gets spread over multiple lines

[pbiggar]

Issue created from fantomas-online

Code

// Actual code
if List.any ((=) (ownerName, username)) specialCases then 6

// Reduced version
((=) (ownerName, username))

Result

// Actual code
if List.any
    ((=)
        (
            ownerName,
            username
        ))
    specialCases then
    6

// Reduced version
((=)
    (
        ownerName,
        username
    ))

Problem description

I would expect this code to be kept in one line:

if List.any ((=) (ownerName, username)) specialCases then 6

Extra information

• The formatted result breaks by code.
• The formatted result gives compiler warnings.
• I or my company would be willing to help fix this.

Options

Fantomas Master at 05/01/2021 14:37:19 - d8e76d4

Default Fantomas configuration

_{Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?}

[nojaf]

This problem was introduced while fixing #1341.
I believe we miss a check whether the code is short in

fantomas/src/Fantomas/CodePrinter.fs

Line 1958 in 0237e8f

| AppParenArg (Choice2Of2 (Paren _, _, _, _, _) as app) -> genAlternativeAppWithParenthesis app astContext

we want something like

        | AppParenArg (Choice2Of2 (Paren _, _, _, _, _) as app) ->
            let short =
                match app with
                | Choice1Of2 (a, lpr, ts, tr, rpr, pr) -> sepNone // TODO
                | Choice2Of2 (a, lpr, p, rpr, pr) -> sepNone // TODO

            let long = genAlternativeAppWithParenthesis app astContext
            expressionFitsOnRestOfLine short long

I don't time right now to provide a complete solution but you might get the idea.
Would you be interested in submitting a PR?

[pbiggar]

Would you be interested in submitting a PR?

Gonna try for an hour or two :)

[nojaf]

Great! You can start out with going through the Contribution Guidelines.
The first set of YouTube videos might also be useful to get started.
Let me know if you have any questions.