base keyword given backticks when overriding with argument

[pbiggar]

Issue created from fantomas-online

Code

type X =  
  override this.f(y) : bool =
    base.f(y)

Result

type X =
    override this.f(y) : bool = ``base``.f (y)

Problem description

base is given backticks by fantomas, which isn't right. Note that if there is no argument to the base method being called, base is not given backticks.

type X =
    override this.f() : bool = base.f()

Extra information

• The formatted result breaks my code.
• The formatted result gives compiler warnings.
• I or my company would be willing to help fix this.

Options

Fantomas master branch at 2022-04-25T16:08:33Z - 2d32fac

    { config with
                MaxLineLength = 80 }

[pbiggar]

Also, omitting the parens around the argument also makes the formatting work correctly:

type X =
    override this.f(y) : bool = base.f y

[nojaf]

Hello, this might be related to dotnet/fsharp#12303.
Perhaps we should roll with our own helper function on when to introduce backticks and when not.

[pbiggar]

Thanks @nojaf!

[nojaf]

This is fix is available at https://github.com/fsprojects/fantomas/releases/tag/v5.0.0-alpha-005.
Please give that a spin to see if there any regressions on your end.
//cc @StachuDotNet