Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Selection yields a type loader exception when built with dotnet 7 sdk #2617

Closed
nojaf opened this issue Nov 9, 2022 · 2 comments · Fixed by #2618
Closed

Format Selection yields a type loader exception when built with dotnet 7 sdk #2617

nojaf opened this issue Nov 9, 2022 · 2 comments · Fixed by #2618
Labels
clitool Area command line tool tooling

Comments

@nojaf
Copy link
Contributor

nojaf commented Nov 9, 2022

Fantomas.Client and fantomas (tool) are impacted by dotnet/fsharp#14275 when (de)serializing the FormatSelectionRange struct.

While a fix will eventually land in the F# compiler, I suggest we avoid the problem by changing the struct to class.

Both sides would need a new version before the problem would be fully resolved. Users that are not using format selection are not impacted by this.

@nojaf nojaf added tooling clitool Area command line tool labels Nov 9, 2022
@auduchinok
Copy link
Contributor

While a fix will eventually land in the F# compiler, I suggest we avoid the problem by changing the struct to class.

@DedSec256 Will that work with Rider integration?

@DedSec256
Copy link
Contributor

DedSec256 commented Nov 9, 2022

@auduchinok, no, since it does not affect Fantomas.Core we are using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clitool Area command line tool tooling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants