Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setter is also private #2902

Closed
4 tasks
nojaf opened this issue Jun 16, 2023 · 1 comment · Fixed by #2903
Closed
4 tasks

Setter is also private #2902

nojaf opened this issue Jun 16, 2023 · 1 comment · Fixed by #2903

Comments

@nojaf
Copy link
Contributor

nojaf commented Jun 16, 2023

Issue created from fantomas-online

Code

module Telplin

type T =
    struct
        member private this.X with get () : int = 1 and set (_:int) = ()
    end

Result

module Telplin

type T =
    struct
        member this.X
            with private get (): int = 1
            and private set (_: int) = ()
    end

Problem description

Something is wrong with ASTTransformer. The set binding should not be private.

Extra information

  • The formatted result breaks my code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.
  • I would like a release if this problem is solved.

Options

Fantomas main branch at 2023-06-08T13:47:44Z - 4f2f9c1

Default Fantomas configuration

Did you know that you can ignore files when formatting by using a .fantomasignore file?
PS: It's unlikely that someone else will solve your specific issue, as it's something that you have a personal stake in.

@nojaf
Copy link
Contributor Author

nojaf commented Jun 16, 2023

The second private is actually irrelevant and should be avoided.

See: 558,parsMultipleAccessibilitiesForGetSet,"Multiple accessibilities given for property getter or setter"

Sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant