Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurse option with globally installed dotnet-tool traverses 'obj' directories (2.9.0) #341

Closed
bdube opened this issue Oct 24, 2018 · 2 comments · Fixed by #400
Closed

Comments

@bdube
Copy link

bdube commented Oct 24, 2018

Is this intentional and necessary?

@nojaf
Copy link
Contributor

nojaf commented Oct 27, 2018

I believe the answer is both no,
Files are found via:

/// Get all appropriate files, either recursively or non-recursively
let rec allFiles isRec path =
    seq {
        for f in Directory.GetFiles path do
            if isFSharpFile f then yield f
        if isRec then
            for d in Directory.GetDirectories path do
                yield! allFiles isRec d
    }

We could add some logic not to look into the obj folder.
Not really a high priority for me personally.

@bdube
Copy link
Author

bdube commented Oct 27, 2018

It's not a terribly high priority for me, either. But thank you for including the relevant code so I can work on a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants