Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest FCS breaks fantomas #410

Closed
7sharp9 opened this issue Feb 1, 2019 · 8 comments
Closed

Latest FCS breaks fantomas #410

7sharp9 opened this issue Feb 1, 2019 · 8 comments

Comments

@7sharp9
Copy link
Member

7sharp9 commented Feb 1, 2019

Description

Latest FCS breaks fantomas, Microsoft.FSharp.Compiler.SourceCodeServices.FSharpLineTokenizer.ScanToken has changed.

Repro code

Build with latest version of FCS

@auduchinok
Copy link
Contributor

I tried building Fantomas with a newer FCS some time ago, the needed changes were: auduchinok@4848b8d
I didn't do much to support newer features, so please check/update/implement needed stuff if cherry-picking.

@nojaf
Copy link
Contributor

nojaf commented Feb 6, 2019

I guess dotnet/fsharp#6189 will lead to a newer FCS.
Will wait for those changes.

@cartermp
Copy link

cartermp commented Mar 5, 2019

Anonymous Records are now a part of the expression API: dotnet/fsharp#6257 - FCS 27.0.1

@nosami
Copy link
Member

nosami commented May 2, 2019

Looks like #427 fixes this. Is there any chance of getting an updated NuGet package so that I can update Fantomas in VSMac without building it myself? Cheers

@nojaf
Copy link
Contributor

nojaf commented May 2, 2019

Please consider the nightly build, https://github.com/fsprojects/fantomas/blob/master/README.md#early-builds

@nosami
Copy link
Member

nosami commented May 3, 2019

λ any → λ  master-vnext* → pwd
/Users/jason/src/monodevelop/main/external/fsharpbinding/packages/fantomas-tool/tools/netcoreapp2.1/any
λ any → λ  master-vnext* → ls -la
total 36128
drwxr-xr-x  25 jason  staff       800 May  2 23:28 .
drwxr-xr-x   3 jason  staff        96 May  2 23:28 ..
-rw-r--r--   1 jason  staff       197 Feb  2 11:10 DotnetToolSettings.xml
-rw-r--r--   1 jason  staff  14734336 Sep  5  2018 FSharp.Compiler.Service.dll
-rw-r--r--   1 jason  staff   2701360 Nov 26 17:51 FSharp.Core.dll
-rw-r--r--   1 jason  staff    743424 Feb  2 11:10 Fantomas.dll
-rw-r--r--   1 jason  staff    172596 Feb  2 11:10 Fantomas.pdb
drwxr-xr-x   3 jason  staff        96 May  2 23:28 cs
drwxr-xr-x   3 jason  staff        96 May  2 23:28 de
drwxr-xr-x   3 jason  staff        96 May  2 23:28 en
drwxr-xr-x   3 jason  staff        96 May  2 23:28 es
-rw-r--r--   1 jason  staff     54121 Feb  2 11:10 fantomas-tool.deps.json
-rw-r--r--   1 jason  staff     57344 Feb  2 11:09 fantomas-tool.dll
-rw-r--r--   1 jason  staff      9136 Feb  2 11:09 fantomas-tool.pdb
-rw-r--r--   1 jason  staff       154 Feb  2 11:10 fantomas-tool.runtimeconfig.json
drwxr-xr-x   3 jason  staff        96 May  2 23:28 fr
drwxr-xr-x   3 jason  staff        96 May  2 23:28 it
drwxr-xr-x   3 jason  staff        96 May  2 23:28 ja
drwxr-xr-x   3 jason  staff        96 May  2 23:28 ko
drwxr-xr-x   3 jason  staff        96 May  2 23:28 pl
drwxr-xr-x   3 jason  staff        96 May  2 23:28 pt-BR
drwxr-xr-x   3 jason  staff        96 May  2 23:28 ru
drwxr-xr-x   3 jason  staff        96 May  2 23:28 tr
drwxr-xr-x   3 jason  staff        96 May  2 23:28 zh-Hans
drwxr-xr-x   3 jason  staff        96 May  2 23:28 zh-Hant

λ any → λ  master-vnext* → dotnet fantomas-tool.dll --version
Fantomas 2.9.2.0
λ any → λ  master-vnext* → ~/.dotnet/tools/fantomas --version
Fantomas 2.9.2.295

If I install the dotnet-cli tool I get the latest nightly version, but the nightly nuget package seems to be old. I tried both fantomas and fantomas-tool from myget.

@nosami
Copy link
Member

nosami commented May 3, 2019

Never mind... looks like the restore went wrong. I can see the latest package that references FCS 27.0.1 on myget. Thanks!

@nojaf
Copy link
Contributor

nojaf commented Aug 30, 2019

Trivia branch is now on FCS 31.
Don't hesitate to create a new issue if you wish to have a beta on NuGet for this.

@nojaf nojaf closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants