Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's a bit confusing that Validation uses Choice instead of Result #428

Open
Tarmil opened this issue Dec 4, 2022 · 3 comments
Open

It's a bit confusing that Validation uses Choice instead of Result #428

Tarmil opened this issue Dec 4, 2022 · 3 comments

Comments

@Tarmil
Copy link

Tarmil commented Dec 4, 2022

I understand that it's because this library is older than the inclusion of the Result type in FSharp.Core. But maybe it would be worth adding a separate Result-based validation module? Maybe even ultimately obsoleting the current Choice-based one.

@gdziadkiewicz
Copy link
Collaborator

I totally agree with that! Let's add a Result-based validation module and deprecated the Choice. In the next major version we can obsolete it. Should I do it or leave it for you?

@Tarmil
Copy link
Author

Tarmil commented Dec 9, 2022

I can work on it.

I'm not sure what the new module should be called though. Validate? Validator? Or maybe still Validation but located in a sub-namespace to avoid collision?

@gdziadkiewicz
Copy link
Collaborator

I like the idea of Validation located in a sub-namespace. With such approach I would be able to simply switch to new implementation by change the open in my code and fixing compiler errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants