-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add print layout for minutes #64
Conversation
Could you use Arial as font? Or does @jeriox have an opinion about the font to use? |
About links: Might be nice to add the full links as footnotes |
Would you create new Issues for the additional stuff in #52 like attachements, so they don't get forgotten? |
@SilvanVerhoeven Thank you for your review!
Yes, of course the real font is nicer than that default font. I was wondering why our font was not applied.
You mean instead of a blue underlining we write [1] and add a list of links at the end? Rendering a list of links should be straightforward, but how would you place the links? Should be a separate issue maybe,
Will do when this is merged, since some changes might still change (Attachments probably not) |
Sure thing, thank you for working on the issue :) @font: I don't know either. One would need to check where the website's font is set and why this rule is not applied to print |
Do we already have Abbreviations? Since in printing those used to be written as the complete words in 1327 which was pretty cool - otherwise I would create an issue for that (Abbreviations in general + printing) |
Abbreviations are implemented. Printing could also be a separate issue. |
@SilvanVerhoeven Font is now there, bootstrap classes are used. |
bb9feb2
to
47ed334
Compare
47ed334
to
a9eb351
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgm! Supposed you create all the issues we talked about
@SilvanVerhoeven could you approve the PR? I think you are more qualified for this :D |
|
oh. I read that as "commented on the PR" 🙈 maybe I should go to bed ^^ |
Fixes #52
See some screenshots here.
Minutes in standard view:
Minutes for printing:
(Information pages were not the focus of this issue)
Information page in standard view: