Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print layout for minutes #64

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Conversation

frcroth
Copy link
Contributor

@frcroth frcroth commented Jun 3, 2022

Fixes #52

See some screenshots here.

Minutes in standard view:
image

Minutes for printing:
image

(Information pages were not the focus of this issue)
Information page in standard view:
image
image

@frcroth frcroth requested review from SilvanVerhoeven and jeriox and removed request for SilvanVerhoeven June 3, 2022 09:45
myhpi/static/css/myHPI.css Outdated Show resolved Hide resolved
myhpi/static/css/myHPI.css Outdated Show resolved Hide resolved
myhpi/static/css/myHPI.css Show resolved Hide resolved
myhpi/static/css/myHPI.css Outdated Show resolved Hide resolved
myhpi/core/templates/core/minutes.html Show resolved Hide resolved
@SilvanVerhoeven
Copy link
Collaborator

Could you use Arial as font? Or does @jeriox have an opinion about the font to use?

@SilvanVerhoeven
Copy link
Collaborator

About links: Might be nice to add the full links as footnotes

@SilvanVerhoeven
Copy link
Collaborator

Would you create new Issues for the additional stuff in #52 like attachements, so they don't get forgotten?

@frcroth
Copy link
Contributor Author

frcroth commented Jun 3, 2022

@SilvanVerhoeven Thank you for your review!

Could you use Arial as font? Or does @jeriox have an opinion about the font to use?

Yes, of course the real font is nicer than that default font. I was wondering why our font was not applied.

About links: Might be nice to add the full links as footnotes

You mean instead of a blue underlining we write [1] and add a list of links at the end? Rendering a list of links should be straightforward, but how would you place the links? Should be a separate issue maybe,

Would you create new Issues for the additional stuff in #52 like attachements, so they don't get forgotten?

Will do when this is merged, since some changes might still change (Attachments probably not)

@SilvanVerhoeven
Copy link
Collaborator

@frcroth

Sure thing, thank you for working on the issue :)

@font: I don't know either. One would need to check where the website's font is set and why this rule is not applied to print
@links: Exactly. Maybe links are simply underlined with [1] or ¹ with the respective footnote at the page's bottom. The most succinct way is probably to add JS like this. A new issue seems appropriate

@Paula-Kli
Copy link
Collaborator

Do we already have Abbreviations? Since in printing those used to be written as the complete words in 1327 which was pretty cool - otherwise I would create an issue for that (Abbreviations in general + printing)

@frcroth
Copy link
Contributor Author

frcroth commented Jun 3, 2022

Do we already have Abbreviations? Since in printing those used to be written as the complete words in 1327 which was pretty cool - otherwise I would create an issue for that (Abbreviations in general + printing)

Abbreviations are implemented. Printing could also be a separate issue.

@frcroth
Copy link
Contributor Author

frcroth commented Jun 3, 2022

@SilvanVerhoeven Font is now there, bootstrap classes are used.

myhpi/static/css/myHPI.css Outdated Show resolved Hide resolved
myhpi/static/css/myHPI.css Outdated Show resolved Hide resolved
Copy link
Collaborator

@SilvanVerhoeven SilvanVerhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgm! Supposed you create all the issues we talked about

@jeriox
Copy link
Contributor

jeriox commented Jun 6, 2022

@SilvanVerhoeven could you approve the PR? I think you are more qualified for this :D

@frcroth
Copy link
Contributor Author

frcroth commented Jun 6, 2022

@SilvanVerhoeven could you approve the PR? I think you are more qualified for this :D

But he has already approved it?
image

@jeriox
Copy link
Contributor

jeriox commented Jun 6, 2022

oh. I read that as "commented on the PR" 🙈 maybe I should go to bed ^^

@frcroth
Copy link
Contributor Author

frcroth commented Jun 6, 2022

oh. I read that as "commented on the PR" 🙈 maybe I should go to bed ^^

Can't merge though without an approval
image

But does not have to be today obviously

@jeriox
Copy link
Contributor

jeriox commented Jun 6, 2022

oh. I read that as "commented on the PR" 🙈 maybe I should go to bed ^^

Can't merge though without an approval image

But does not have to be today obviously

should work now

@frcroth frcroth merged commit 031edca into fsr-de:main Jun 6, 2022
@frcroth frcroth deleted the feature/print-minutes branch June 6, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Print layout
4 participants