Simple passwords #308
Merged
Simple passwords #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this not also require a change to the Django settings? |
|
yes it does. thanks! |
|
Just for completeness: did one of you test this? Looks good to me, but would like the peace of mind |
|
no, i didn't test this. this time i did a full text search through the repo, there were no other occurrences of the password. but i can test this later, either in a few hours or monday evening. |
|
This would be most appreciated |
|
tested. vagrant up works, |
|
assuming your "looks good to me" is an approval. |
|
Yes it was, thanks for testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR sets the database passwords in the vagrant VM to 'evap'.
i repeatedly found myself opening site.pp, copy the password and paste it into my shell, which shouldn't be necessary IMO.