Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour when directories aren't explicitly created #63

Closed
jamesmyatt opened this issue Jun 8, 2020 · 3 comments
Closed

Comments

@jamesmyatt
Copy link
Contributor

jamesmyatt commented Jun 8, 2020

See this unit test in #62, which fails: 6eb9574

The first failure is at the line:

assert fs.ls("test_deep") == ["test_deep/a/"]

which fails because ls throws a FileNotFoundError. Since the container was created, it certainly shouldn't give FileNotFound.

update: #64 might be more fundamental and the fix for that might fix this.

@hayesgb
Copy link
Collaborator

hayesgb commented Jun 14, 2020

I incorporated your additional tests into master. It is still failing, but current master branch returns:
assert fs.ls("test_deep") == ["test_deep/a/"] E AssertionError: assert ['test_deep/a/b/'] == ['test_deep/a/'] E At index 0 diff: 'test_deep/a/b/' != 'test_deep/a/' E Full diff: E - ['test_deep/a/'] E + ['test_deep/a/b/'] E ? ++

@hayesgb
Copy link
Collaborator

hayesgb commented Dec 13, 2020

Now passing deep_paths tests

@hayesgb hayesgb closed this as completed Dec 13, 2020
@jamesmyatt
Copy link
Contributor Author

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants