Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing azure.common, which is no longer part of 'install_requires' #74

Closed
andersbogsnes opened this issue Jul 8, 2020 · 1 comment

Comments

@andersbogsnes
Copy link
Contributor

What happened:
If AzureBlobFilesystem._get_token_from_service_principal is called, it will raise an import error as azure.common is no longer part of the requirements

https://github.com/dask/adlfs/blob/1778049d1b341d8526a412efcaa70ff7b81b0521/adlfs/core.py#L362

I can't find any reference to token_credentials being used anywhere, so this might just be a dead code path, in which case I can remove it in a PR.

Since I'm not sure what token_credential is actually used for, I don't know what to substitute it with - otherwise I would just make a PR fixing it

@hayesgb
Copy link
Collaborator

hayesgb commented Aug 2, 2020

This import will be removed in the latest release, which fixes the ability to authenticate with a ServicePrincipal.

@hayesgb hayesgb closed this as completed Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants