Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "KeyError: 'type' using fs.glob" #34 #36

Closed
wants to merge 1 commit into from

Conversation

lassevalentini
Copy link

@lassevalentini lassevalentini commented Jan 22, 2020

Add return statement to handle folders being the prefix of another folder during ls operations. Fixes #34 for me.

I'm not super familiar with the code, but this fixes my issue and seems like it it was the original intention (as the self.ls seems pointless otherwise).

@martindurant
Copy link
Member

Please check if #35 already fixes this for you.

@lassevalentini
Copy link
Author

#35 fixes the issue for a small test sample I have constructed.

However, doing a glob on abfs://container/raw_financials/*/*.parquet or abfs://container/raw_financials/**.parquet on a directory structure with 15k folders yields nothing.

I've tested the same glob with this code, and it only yields ~600, which is not correct either, so my guess would be that there's a limit/timeout on some operations to azure rather than on the code itself.

@martindurant
Copy link
Member

^ cc @AlbertDeFusco , maybe you need some more tests?

@AlbertDeFusco
Copy link
Contributor

Certainly. I'm working on the large file/directory tests.

@lassevalentini
Copy link
Author

Ill close this PR as it should be solved with #35 which is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'type' using fs.glob
3 participants