Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adlfs: get rid of versioneer and cleanup building #446

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

efiop
Copy link
Member

@efiop efiop commented Dec 22, 2023

It is currently breaking our CI and it is not needed anyways.

Run python -m pip install -e .[docs]
Obtaining file:///home/runner/work/adlfs/adlfs
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Checking if build backend supports build_editable: started
  Checking if build backend supports build_editable: finished with status 'done'
  Getting requirements to build editable: started
  Getting requirements to build editable: finished with status 'error'
  error: subprocess-exited-with-error
  
  × Getting requirements to build editable did not run successfully.
  │ exit code: 1
  ╰─> [34 lines of output]
      /home/runner/work/adlfs/adlfs/versioneer.py:432: SyntaxWarning: invalid escape sequence '\s'
        ] = '''
      Traceback (most recent call last):
        File "/opt/hostedtoolcache/Python/3.12.1/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/opt/hostedtoolcache/Python/3.12.1/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/opt/hostedtoolcache/Python/3.12.1/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 132, in get_requires_for_build_editable
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-djigs1hj/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 441, in get_requires_for_build_editable
          return self.get_requires_for_build_wheel(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-djigs1hj/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-djigs1hj/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-djigs1hj/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 4[8](https://github.com/fsspec/adlfs/actions/runs/7302526062/job/19901312066#step:4:9)0, in run_setup
          super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
        File "/tmp/pip-build-env-djigs1hj/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 3[11](https://github.com/fsspec/adlfs/actions/runs/7302526062/job/19901312066#step:4:12), in run_setup
          exec(code, locals())
        File "<string>", line 11, in <module>
        File "/home/runner/work/adlfs/adlfs/versioneer.py", line 1524, in get_version
          return get_versions()["version"]
                 ^^^^^^^^^^^^^^
        File "/home/runner/work/adlfs/adlfs/versioneer.py", line [14](https://github.com/fsspec/adlfs/actions/runs/7302526062/job/19901312066#step:4:15)51, in get_versions
          cfg = get_config_from_root(root)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/home/runner/work/adlfs/adlfs/versioneer.py", line [34](https://github.com/fsspec/adlfs/actions/runs/7302526062/job/19901312066#step:4:35)6, in get_config_from_root
          parser = configparser.SafeConfigParser()
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.
Error: Process completed with exit code 1.

Also cleaning up build files/process along the way as it is easier to make setuptools_scm migration that way.

@efiop
Copy link
Member Author

efiop commented Dec 22, 2023

Docs building is fixed, but regular test failures are unrelated, will handle in a followup.

@efiop efiop merged commit 18f0b0b into fsspec:main Dec 22, 2023
1 of 4 checks passed
Comment on lines +7 to +8
from ._dvc_version import version as __version__ # type: ignore[import]
from ._dvc_version import version_tuple # type: ignore[import]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from ._dvc_version import version as __version__ # type: ignore[import]
from ._dvc_version import version_tuple # type: ignore[import]
from ._version import version as __version__ # type: ignore[import]
from ._version import version_tuple # type: ignore[import]

efiop added a commit that referenced this pull request Dec 23, 2023
@efiop efiop mentioned this pull request Dec 23, 2023
efiop added a commit that referenced this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants