Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: pin pytest-asyncio to 0.21.1 #447

Merged
merged 1 commit into from
Dec 22, 2023
Merged

tests: pin pytest-asyncio to 0.21.1 #447

merged 1 commit into from
Dec 22, 2023

Conversation

efiop
Copy link
Member

@efiop efiop commented Dec 22, 2023

With newer versions we get a lot of errors like:

____________________________ test_isfile_versioned _____________________________

self = <Coroutine test_isfile_versioned>

    def runtest(self) -> None:
        self.obj = wrap_in_sync(
            # https://github.com/pytest-dev/pytest-asyncio/issues/596
            self.obj,  # type: ignore[has-type]
        )
>       super().runtest()

/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pytest_asyncio/plugin.py:431:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pytest_asyncio/plugin.py:879: in inner
    _loop.run_until_complete(task)
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/base_events.py:592: in run_until_complete
    self._check_running()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <_UnixSelectorEventLoop running=True closed=False debug=False>

    def _check_running(self):
        if self.is_running():
>           raise RuntimeError('This event loop is already running')
E           RuntimeError: This event loop is already running

/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/base_events.py:552: RuntimeError

Don't know precise reason and maybe using nest-asyncio package would fix that, but for now just pinning older version to move forward.

With newer versions we get a lot of errors like:

```
____________________________ test_isfile_versioned _____________________________

self = <Coroutine test_isfile_versioned>

    def runtest(self) -> None:
        self.obj = wrap_in_sync(
            # pytest-dev/pytest-asyncio#596
            self.obj,  # type: ignore[has-type]
        )
>       super().runtest()

/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pytest_asyncio/plugin.py:431:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pytest_asyncio/plugin.py:879: in inner
    _loop.run_until_complete(task)
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/base_events.py:592: in run_until_complete
    self._check_running()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <_UnixSelectorEventLoop running=True closed=False debug=False>

    def _check_running(self):
        if self.is_running():
>           raise RuntimeError('This event loop is already running')
E           RuntimeError: This event loop is already running

/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/base_events.py:552: RuntimeError
```

Don't know precise reason and maybe using nest-asyncio package would fix that, but for now
just pinning older version to move forward.
@efiop
Copy link
Member Author

efiop commented Dec 22, 2023

Last two tests failng are because of fsspec/filesystem_spec#1382 , will be fixed in a followup.

@efiop efiop merged commit ff919cf into fsspec:main Dec 22, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant