Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stringify url in url_to_fs #1591

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Stringify url in url_to_fs #1591

merged 1 commit into from
Apr 23, 2024

Conversation

mariosasko
Copy link
Contributor

@mariosasko mariosasko commented Apr 23, 2024 •
edited

Call stringify_path on the url value in url_to_fs to be consistent with get_fs_token_paths.

@mariosasko
Copy link
Contributor Author

This minor inconsistency has caused us problems in datasets: huggingface/datasets#6829.

@martindurant
Copy link
Member

I am sad to see the proliferation of Path in python (jokes)

@martindurant martindurant merged commit 69f4fe8 into fsspec:master Apr 23, 2024
11 checks passed
@mariosasko mariosasko deleted the url_to_fs-stringify-path branch April 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mariosasko @martindurant