Skip gcsfs registration to dask if dask is not installed #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcsfs/dask_link.py
Outdated
| @@ -118,7 +120,6 @@ def walk(self, path, refresh=False): | |||
| dask.bytes.core._filesystems['gs'] = DaskGCSFileSystem | |||
|
|
|||
|
|
|||
| try: | |||
| # Register to dask if dask is installed | |||
| if 'dask' in sys.modules: | |||
There was a problem hiding this comment.
This doesn't do what you think, it requires dask to have been already imported. Therefore, if gcsfs happens to be imported before dask, register will never be called.
| register() | ||
| except ImportError as e: | ||
| print(e) |
There was a problem hiding this comment.
I suggest the easiest thing to do here is to change the print to a logger.debug statement, so it doesn't normally show unless the user enables debug logging.
There was a problem hiding this comment.
Hi Martin,
Thanks for pointing it out. Yes, logger.debug will be much easier. Thanks for the suggestion.
Best,
Qibin
qibin-google
force-pushed
the
master
branch
2 times, most recently
from
edf6160
to
df5f4c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.