Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using google.auth #62

Merged
merged 10 commits into from
Jan 10, 2018
Merged

using google.auth #62

merged 10 commits into from
Jan 10, 2018

Conversation

martindurant
Copy link
Member

Use new purpose-built package to generate sessions and handle refresh,
simplifying our code.

Follows from #58
Fixes #59
Fixes #60
May help with #61

Martin Durant added 2 commits January 8, 2018 13:25
Use new purpose-built package to generate sessions and handle refresh,
simplifying our code.
@mrocklin
Copy link
Contributor

mrocklin commented Jan 8, 2018

cc @asford, whenever you're around

@martindurant
Copy link
Member Author

One outstanding question: if you use the google default credentials, you get the default project too, but I think every other method requires you to provide a project if you want to be able to list buckets. anon, of course, makes no use of the project.
Second: passing a token explicitly is now broken. Do we still want to allow a dict as input, or should it be a Credentials object (reminder, there is now a conversion function for the particularl dict style used in the previous version).

Naturally, documentation etc will need to be updated.

@mrocklin
Copy link
Contributor

mrocklin commented Jan 8, 2018 via email

@asford
Copy link
Collaborator

asford commented Jan 9, 2018

Picking up the default project along with default credentials would be ideal, if possible. This would allow zero-configuration use of gcsfs in cases when someone is already using google-cloud-sdk, which seems like the most common user scenario.

In my opinion I would be best to just converge on using the google.auth API and accept an explicit Credentials object. Does google.auth have support for reading credentials objects from files in the json format generated by gcloud auth?

Thanks for moving quickly on this!

@martindurant martindurant changed the title WIP: using google.auth using google.auth Jan 9, 2018
@martindurant martindurant merged commit 789459f into fsspec:master Jan 10, 2018
@martindurant martindurant deleted the google_auth branch January 10, 2018 14:58
@martindurant martindurant mentioned this pull request Jan 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants