Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation instructions #22

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Add installation instructions #22

merged 3 commits into from
Jun 21, 2023

Conversation

davidgasquez
Copy link
Contributor

Hey there! Saw the installation were missing on the README.

@davidgasquez
Copy link
Contributor Author

@d70-t, any thoughts on this?

Copy link
Collaborator

@d70-t d70-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @davidgasquez, thanks for the initiative! I've been away for the last 5 weeks and just slowly catching up, thus answering only that late.

I guess the official way of installing would be to install the latest released version via pypi, thus just using the package name in the command. Your suggestion would install the current (maybe unreleased) main branch.

README.md Outdated Show resolved Hide resolved
@d70-t
Copy link
Collaborator

d70-t commented Jun 20, 2023

I've had a look into the CI errors above. The are seemingly related to updates to common IPFS servers which had not yet been accounted for in the code. I've added a few updates to the current main. If you'd merge or rebase, the errors should go away.

@davidgasquez
Copy link
Contributor Author

Thanks for jumping in!

I guess the official way of installing would be to install the latest released version via pypi, thus just using the package name in the command. Your suggestion would install the current (maybe unreleased) main branch.

Agree!

I've added a few updates to the current main. If you'd merge or rebase, the errors should go away.

✔️

@d70-t
Copy link
Collaborator

d70-t commented Jun 21, 2023

Thanks for updating! 🎉

@d70-t d70-t merged commit 412c542 into fsspec:main Jun 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants