Do not use auto HDF5 fill value for netcdf-derived variables #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay to merge? Or do you want a review or more testing? |
|
I'm OK to merge it, but if there are any case studies likely to be tried in the next few days, I would wait. |
|
@pnorton-usgs, are there any other tests you might have handy? |
|
I re-kerchunked our National Hydrologic Model output and verified that the HDF5 fill value is no longer used in the output json. The datatypes that were being converted to float are now remaining integers. Thanks for the quick fix on this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #284