Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add passthrough extras for boto3 and awscli #362

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

graingert
Copy link
Contributor

Fixes #357

@graingert
Copy link
Contributor Author

I'm not 💯% sure this will work - upload it to test.pypi.org first?

@martindurant
Copy link
Member

upload it to test.pypi.org first?

What do I need to do?

@graingert
Copy link
Contributor Author

graingert commented Sep 9, 2020

@martindurant https://packaging.python.org/guides/using-testpypi/

@thehesiod if this works I think we should recommend it: https://github.com/aio-libs/aiobotocore/pull/830/files

but it might be all over by Halloween when pip 20.3 releases

@jrbourbeau
Copy link
Contributor

@graingert you should be able to try out the extras_requires by installing directly from GitHub

pip install "git+https://github.com/graingert/s3fs@patch-1#egg=s3fs[boto3]"

@graingert
Copy link
Contributor Author

hmm it doesn't seem to work with pip-compile or pip 20.2 :(

https://gist.github.com/graingert/b8c9fa1c3a018310d35146ff24587b3d

@martindurant
Copy link
Member

This isn't right?

botocore==1.17.44 \
    --hash=sha256:1b46ffe1d13922066c873323186cbf97e77c137e08e27039d9d684552ccc4892 \
    --hash=sha256:1f6175bf59ffa068055b65f7d703eb1f748c338594a40dfdc645a6130280d8bb \
    # via aiobotocore

@graingert
Copy link
Contributor Author

it's supposed to install boto3==1.14.44

@martindurant
Copy link
Member

...but it's botocore that actually matters :)

@graingert
Copy link
Contributor Author

sure but it's only a problem if boto3 is added without a pin:

pip install s3fs boto3

@graingert
Copy link
Contributor Author

@graingert
Copy link
Contributor Author

graingert commented Sep 9, 2020

@martindurant ok so it turns out delegated/passthrough extras don't work without --use-feature=2020-resolver, so this doesn't really help

(it does make resolving much faster though: https://www.irccloud.com/pastebin/gU599gxM/

@thehesiod
Copy link

ya I've wanted to use this at work as well and found this bug: pypa/pip#3516

@martindurant
Copy link
Member

Do you want to reboot this PR now?

Base automatically changed from master to main February 11, 2021 01:48
@graingert
Copy link
Contributor Author

yep these work for me on pip21

@graingert
Copy link
Contributor Author

it's also probably worth yanking any of the old releases without .whl files, this way the 2020-resolver won't try to download and execute them - which is pretty slow, and in the future will be able to use --use-feature=fast-deps to download only the metadata portions of .whl files

@martindurant martindurant merged commit f5ce7c0 into fsspec:main Mar 17, 2021
@graingert graingert deleted the patch-1 branch March 16, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on aiobotocore renders packaging s3fs no longer possible
4 participants