-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add passthrough extras for boto3 and awscli #362
Conversation
I'm not 💯% sure this will work - upload it to test.pypi.org first? |
What do I need to do? |
@martindurant https://packaging.python.org/guides/using-testpypi/ @thehesiod if this works I think we should recommend it: https://github.com/aio-libs/aiobotocore/pull/830/files but it might be all over by Halloween when pip 20.3 releases |
@graingert you should be able to try out the
|
hmm it doesn't seem to work with pip-compile or pip 20.2 :( https://gist.github.com/graingert/b8c9fa1c3a018310d35146ff24587b3d |
This isn't right?
|
it's supposed to install |
...but it's botocore that actually matters :) |
sure but it's only a problem if boto3 is added without a pin:
|
@martindurant ok so it turns out delegated/passthrough extras don't work without (it does make resolving much faster though: https://www.irccloud.com/pastebin/gU599gxM/ |
ya I've wanted to use this at work as well and found this bug: pypa/pip#3516 |
Do you want to reboot this PR now? |
yep these work for me on pip21 |
it's also probably worth yanking any of the old releases without |
Fixes #357