Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aio session is no longer top level #510

Merged
merged 3 commits into from Aug 20, 2021

Conversation

gadomski
Copy link
Contributor

Since https://github.com/aio-libs/aiobotocore/releases/tag/1.4.0, AioSession no longer exists in the top-level namespace. This PR also:

  • pins the aiobotocore dependency more strictly, since the project demonstrated that it will do backwards-incompatible changes with a minor bump, and
  • pins the extras_require dependencies; they were previously unpinned.

My local test runs are failing but I don't think its due to this change (they were failing on main) so apologies if CI fails.

Since https://github.com/aio-libs/aiobotocore/releases/tag/1.4.0,
AioSession no longer exists in the top-level namespace.
https://github.com/aio-libs/aiobotocore/releases/tag/1.4.0 introduced a
backwards-incompatible change, so we need to only allow tiny to flex for
the future.
setup.py Outdated Show resolved Hide resolved
@gadomski gadomski force-pushed the aio-session-no-longer-top-level branch from 7a61cd5 to 6455e9e Compare August 20, 2021 13:20
@martindurant
Copy link
Member

Thanks for the fix, all appears to be well.

Otherwise, they'll just grab latest-and-greatest.
@gadomski gadomski force-pushed the aio-session-no-longer-top-level branch from 6455e9e to ce6951b Compare August 20, 2021 13:23
gadomski added a commit to stactools-packages/alos-dem that referenced this pull request Aug 20, 2021
They did a backwards-incompatible minor version bump in 1.4.0. Once
fsspec/s3fs#510 is released, we can un-pin.

This should probably propagate all the way to stactools.
@martindurant
Copy link
Member

Fixes #511

@martindurant martindurant merged commit 709326b into fsspec:main Aug 20, 2021
@gadomski gadomski deleted the aio-session-no-longer-top-level branch August 20, 2021 13:42
gadomski added a commit to stactools-packages/alos-dem that referenced this pull request Aug 20, 2021
They did a backwards-incompatible minor version bump in 1.4.0. Once
fsspec/s3fs#510 is released, we can un-pin.

This should probably propagate all the way to stactools.
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Nov 9, 2021
Reverse dependencies:

* python-xarray - two tests use aiobotocore
    * one is skipped [1] as python-zarr is not in [community]
    * another works with aiobotocore 2.0.0
* python-aws-xray-sdk - needs a local patch (upcoming)
* python-s3fs (the only AUR package that depends on python-aiobotocore per RPC v5)
    * compatible since 2021.08.0 [2], and the AUR package is updated

[1] https://github.com/pydata/xarray/blob/v0.20.1/xarray/tests/test_backends.py#L2401
[2] fsspec/s3fs#510


git-svn-id: file:///srv/repos/svn-community/svn@1039359 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Nov 9, 2021
Reverse dependencies:

* python-xarray - two tests use aiobotocore
    * one is skipped [1] as python-zarr is not in [community]
    * another works with aiobotocore 2.0.0
* python-aws-xray-sdk - needs a local patch (upcoming)
* python-s3fs (the only AUR package that depends on python-aiobotocore per RPC v5)
    * compatible since 2021.08.0 [2], and the AUR package is updated

[1] https://github.com/pydata/xarray/blob/v0.20.1/xarray/tests/test_backends.py#L2401
[2] fsspec/s3fs#510

git-svn-id: file:///srv/repos/svn-community/svn@1039359 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants