-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump aiobotocore to 2.1.0 #564
Conversation
In general, we are happy to keep up with the latest aiobotocore , unless of course it needs us to fix something. |
Also, feel free to relax the aiohttp<=4 |
Thank you for your comment! s3fs depends on aiobotocore~=2.0.1, fsspec==2021.11.1, aiohttp<=4
The latest versions of aiohttp and fsspec are 3.8.1 and 2021.11.1 respectively. So for now, I won't ask for updating other packages(Including aiohttp). Please let me request to update them in the future if necessary. https://github.com/aio-libs/aiohttp/tags |
You will also want to change the version in the CI as well Line 36 in a6630f1
|
420ced3
to
a6a2d83
Compare
a6a2d83
to
7fc91e4
Compare
OK. I also updated the version in the CI. |
It seems like aiobotocore 2.1.0 has not yet made it to conda-forge. Let's wait until it does! |
It looks like it. OK. I see! |
Waiting for conda-forge/aiobotocore-feedstock#46 to be solved. |
Thank you, guenhter! Now it seems like aiobotocore 2.1.0 has made it to conda-forge. @martindurant Could you please retrigger CI and check this PR again? |
@martindurant Great that this has been merged. When do you think a new version will be available on pip containing this change? |
I have been meaning to do it last week, but got busy. So, soon? |
I don't want to put any pressure on you :) |
aiobotocore is one of the dependencies of s3fs.
I have updated aiobotocore from 2.0.1 to the latest 2.1.0.
[Background]
boto is used by many different libraries, so it is difficult to lock the boto version.
When I use botocore 1.23.0 or later, I face and opened this issue aio-libs/aiobotocore#905
And this issue has been resolved by this PR aio-libs/aiobotocore#909
Updated version was released with aiobotocore 2.1.0 So I want to use this version from s3fs.
I'll show the log after applying my PR.
Before
After
Thank you,