Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webdav tests #107

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Fix webdav tests #107

merged 3 commits into from
Jun 21, 2023

Conversation

ap--
Copy link
Collaborator

@ap-- ap-- commented Jun 20, 2023

Close #106 (hopefully 馃ゲ )

cpython pathlib tests use a special implementation of rmtree on windows that waits up to 1 second on file tree removal. My guess is this might circumvent the issues we're seeing with flaky webdav dir removal and crashes in the webdav fixture

@ap--
Copy link
Collaborator Author

ap-- commented Jun 20, 2023

Waiting for #105

@ap-- ap-- merged commit 62e1c3d into fsspec:main Jun 21, 2023
14 checks passed
ap-- added a commit to ap--/universal_pathlib that referenced this pull request Jun 22, 2023
ap-- added a commit that referenced this pull request Jun 23, 2023
* Revert "Fix webdav tests (#107)"

This reverts commit 62e1c3d.

* upath.tests: switch root folder for each test for webdav app

* tests: fix webdav tests windows
@ap-- ap-- mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webdav tests sporadically error on windows
1 participant