Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings on updating fstar-mode #27

Closed
nikswamy opened this issue Oct 28, 2015 · 3 comments
Closed

Warnings on updating fstar-mode #27

nikswamy opened this issue Oct 28, 2015 · 3 comments

Comments

@nikswamy
Copy link
Contributor

I did a list-packages, chose fstar-mode, and clicked on Install. I got the messages below. Is this expected? Or, should I fix my emacs configuration in some way?

Compiling file c:/Users/nswamy/.emacs.d/elpa/fstar-mode-20151023.753/fstar-mode-pkg.el at Wed Oct 28 07:58:21 2015
Entering directory `c:/Users/nswamy/.emacs.d/elpa/fstar-mode-20151023.753/'

Compiling file c:/Users/nswamy/.emacs.d/elpa/fstar-mode-20151023.753/fstar-mode.el at Wed Oct 28 07:58:21 2015
fstar-mode.el:99:17:Warning: reference to free variable `flycheck-checkers'
fstar-mode.el:99:17:Warning: assignment to free variable `flycheck-checkers'

In fstar-setup-interactive:
fstar-mode.el:1132:19:Warning: reference to free variable
    `flycheck-disabled-checkers'
fstar-mode.el:1132:19:Warning: assignment to free variable
    `flycheck-disabled-checkers'

In end of data:
fstar-mode.el:1214:1:Warning: the following functions are not known to be defined:
    flycheck-define-command-checker,
    flycheck-increment-error-columns, flycheck-mode
@cpitclaudel
Copy link
Contributor

Hey Nik,

Could this be an old Emacs?

@nikswamy
Copy link
Contributor Author

I'm using GNU Emacs 24.5.1 (i686-pc-mingw32)

@cpitclaudel
Copy link
Contributor

Everything is fine then; I just need to review my definition of "old Emacs" :)
The offending code looks like this:

(when (featurep 'flycheck)
  (do-something-that-requires-flycheck))

The trick is that the warnings in Emacs < 25 are not smart enough to see that the code is surrounded by a (featurep) check. This code won't run unless flycheck is installed, and then it will be fine. Flycheck was useful for real-time checking of small files, but the interactive mode mostly replaced it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants