Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several Qt deprecation warnings #67

Merged
merged 4 commits into from
Feb 16, 2021
Merged

Fix several Qt deprecation warnings #67

merged 4 commits into from
Feb 16, 2021

Conversation

sur5r
Copy link
Contributor

@sur5r sur5r commented Feb 15, 2021

QString::null, QWheelEvent::pos and QWheelEvent::delta are deprecated.

mboerwinkle
mboerwinkle approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@mboerwinkle mboerwinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Removed compiler errors without breaking anything on Archlinux/Qt5.15.2.

@sur5r
Copy link
Contributor Author

sur5r commented Feb 16, 2021

Additional note: QWheelEvent::position() requires at least Qt 5.14. It might be wise to add a Qt version check to the cmake configuration.

@DeveloperPaul123
Copy link
Member

Looks good to me thanks for the changes.

@DeveloperPaul123 DeveloperPaul123 merged commit 18e0e59 into fstl-app:master Feb 16, 2021
@Lenbok
Copy link

Lenbok commented Sep 4, 2021

This commit breaks the ability to build fstl on Ubuntu 20.04 LTS, since only Qt 5.12 is available there.

Lenbok added a commit to Lenbok/fstl that referenced this pull request Sep 4, 2021
@Lenbok
Revert "Fix several Qt deprecation warnings (fstl-app#67)"
ee1e830 
This reverts commit 18e0e59.
@Lenbok Lenbok mentioned this pull request Sep 4, 2021
Open
@sur5r sur5r deleted the deprecationfix branch September 8, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboerwinkle mboerwinkle mboerwinkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sur5r @DeveloperPaul123 @Lenbok @mboerwinkle