New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show and Eq instances for cats #284
Conversation
This prevents MiMa from checking this module
Thanks for the mima fix. Let me know if you want me to squash the commit so there isn't a broken build in the history. |
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 99.25% 99.25% +<.01%
==========================================
Files 35 36 +1
Lines 401 403 +2
Branches 3 3
==========================================
+ Hits 398 400 +2
Misses 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @derekmorr! There is an import in initialCommands
which probably can be removed, otherwise this LGTM.
Also, there is no need to manually squash the commits, I'll can always do this via GitHub on merge.
build.sbt
Outdated
libraryDependencies += "org.typelevel" %%% "cats-core" % catsVersion, | ||
initialCommands += s""" | ||
import $rootPkg.cats._ | ||
import $rootPkg.cats.auto._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no cats.auto
object in this PR. Running cats/console
will fail with an error, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, my mistake. I'll update the PR.
This adds cats
Show
andEq
instances for refined types, similar to the scalaz module.