Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show and Eq instances for cats #284

Merged
merged 3 commits into from May 30, 2017
Merged

Conversation

derekmorr
Copy link
Contributor

This adds cats Show and Eq instances for refined types, similar to the scalaz module.

This prevents MiMa from checking this module
@derekmorr
Copy link
Contributor Author

Thanks for the mima fix. Let me know if you want me to squash the commit so there isn't a broken build in the history.

@codecov-io
Copy link

codecov-io commented May 30, 2017

Codecov Report

Merging #284 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   99.25%   99.25%   +<.01%     
==========================================
  Files          35       36       +1     
  Lines         401      403       +2     
  Branches        3        3              
==========================================
+ Hits          398      400       +2     
  Misses          3        3
Impacted Files Coverage Δ
...c/main/scala/eu/timepit/refined/cats/package.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1987af0...2488cb1. Read the comment docs.

Copy link
Owner

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @derekmorr! There is an import in initialCommands which probably can be removed, otherwise this LGTM.

Also, there is no need to manually squash the commits, I'll can always do this via GitHub on merge.

build.sbt Outdated
libraryDependencies += "org.typelevel" %%% "cats-core" % catsVersion,
initialCommands += s"""
import $rootPkg.cats._
import $rootPkg.cats.auto._
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no cats.auto object in this PR. Running cats/console will fail with an error, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, my mistake. I'll update the PR.

@fthomas fthomas merged commit a2c300d into fthomas:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants