Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Validate.fromPartial #336

Merged
merged 1 commit into from Oct 2, 2017
Merged

Conversation

fthomas
Copy link
Owner

@fthomas fthomas commented Oct 1, 2017

Benchmark results for this change:

master:
[info] Result "eu.timepit.refined.benchmark.RefineVBenchmark.refineV_Regex":
[info]   121.400 ±(99.9%) 1.297 ns/op [Average]
[info]   (min, avg, max) = (110.969, 121.400, 159.030), stdev = 5.493
[info]   CI (99.9%): [120.103, 122.698] (assumes normal distribution)
[info] # Run complete. Total time: 00:06:43
[info] Benchmark                       Mode  Cnt    Score   Error  Units
[info] RefineVBenchmark.refineV_Regex  avgt  200  121.400 ± 1.297  ns/op

this branch:
[info] Result "eu.timepit.refined.benchmark.RefineVBenchmark.refineV_Regex":
[info]   108.263 ±(99.9%) 0.893 ns/op [Average]
[info]   (min, avg, max) = (100.935, 108.263, 138.393), stdev = 3.780
[info]   CI (99.9%): [107.370, 109.156] (assumes normal distribution)
[info] # Run complete. Total time: 00:06:43
[info] Benchmark                       Mode  Cnt    Score   Error  Units
[info] RefineVBenchmark.refineV_Regex  avgt  200  108.263 ± 0.893  ns/op

Benchmark results for this change:
```
master:
[info] Result "eu.timepit.refined.benchmark.RefineVBenchmark.refineV_Regex":
[info]   121.400 ±(99.9%) 1.297 ns/op [Average]
[info]   (min, avg, max) = (110.969, 121.400, 159.030), stdev = 5.493
[info]   CI (99.9%): [120.103, 122.698] (assumes normal distribution)
[info] # Run complete. Total time: 00:06:43
[info] Benchmark                       Mode  Cnt    Score   Error  Units
[info] RefineVBenchmark.refineV_Regex  avgt  200  121.400 ± 1.297  ns/op

this branch:
[info] Result "eu.timepit.refined.benchmark.RefineVBenchmark.refineV_Regex":
[info]   108.263 ±(99.9%) 0.893 ns/op [Average]
[info]   (min, avg, max) = (100.935, 108.263, 138.393), stdev = 3.780
[info]   CI (99.9%): [107.370, 109.156] (assumes normal distribution)
[info] # Run complete. Total time: 00:06:43
[info] Benchmark                       Mode  Cnt    Score   Error  Units
[info] RefineVBenchmark.refineV_Regex  avgt  200  108.263 ± 0.893  ns/op
```
@codecov
Copy link

codecov bot commented Oct 1, 2017

Codecov Report

Merging #336 into master will decrease coverage by 2.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage    99.1%   96.53%   -2.57%     
==========================================
  Files          38       38              
  Lines         447      462      +15     
  Branches        8        9       +1     
==========================================
+ Hits          443      446       +3     
- Misses          4       16      +12
Impacted Files Coverage Δ
...c/main/scala/eu/timepit/refined/api/Validate.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25cc3e2...2fcc42e. Read the comment docs.

@fthomas fthomas merged commit 6f01d6f into master Oct 2, 2017
@fthomas fthomas deleted the topic/optimize_fromPartial branch October 2, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant