Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predicates for string #492

Merged
merged 5 commits into from
Apr 30, 2018
Merged

Conversation

sh0hei
Copy link
Contributor

@sh0hei sh0hei commented Apr 28, 2018

  • ValidByte
  • ValidShort
  • ValidFloat

@codecov
Copy link

codecov bot commented Apr 28, 2018

Codecov Report

Merging #492 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   94.31%   94.33%   +0.02%     
==========================================
  Files          62       62              
  Lines         668      671       +3     
  Branches       13       13              
==========================================
+ Hits          630      633       +3     
  Misses         38       38
Impacted Files Coverage Δ
...red/src/main/scala/eu/timepit/refined/string.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c9297...73f8a75. Read the comment docs.

@fthomas
Copy link
Owner

fthomas commented Apr 28, 2018

This LGTM, thanks @sh0hei!
Could you do me a favor and add this change to the release notes (notes/0.9.1.markdown)?

@sh0hei
Copy link
Contributor Author

sh0hei commented Apr 29, 2018

Sorry I did not notice.
added to notes/0.9.1.markdown 👍

@fthomas
Copy link
Owner

fthomas commented Apr 30, 2018

Thanks!

@fthomas fthomas merged commit 1232d2b into fthomas:master Apr 30, 2018
@sh0hei sh0hei deleted the feature/valid-number branch May 1, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants