Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve specs #493

Merged
merged 3 commits into from
May 18, 2018
Merged

Improve specs #493

merged 3 commits into from
May 18, 2018

Conversation

rider-yi
Copy link
Contributor

@rider-yi rider-yi commented Apr 29, 2018

Added some tests for refined types

@codecov
Copy link

codecov bot commented Apr 30, 2018

Codecov Report

Merging #493 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #493     +/-   ##
=========================================
- Coverage   94.26%   93.97%   -0.3%     
=========================================
  Files          62       62             
  Lines         680      680             
  Branches       10       10             
=========================================
- Hits          641      639      -2     
- Misses         39       41      +2
Impacted Files Coverage Δ
.../scala/eu/timepit/refined/api/RefinedTypeOps.scala 80% <0%> (-20%) ⬇️
...ain/scala/eu/timepit/refined/api/RefinedType.scala 88.88% <0%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08eeb59...1a12e79. Read the comment docs.

@rider-yi rider-yi changed the title Improve NumericTypesSpec Improve specs May 1, 2018
@rider-yi rider-yi force-pushed the improve_numeric_types_spec branch from 9be4360 to 3378375 Compare May 1, 2018 02:04
@kusamakura
Copy link
Contributor

I think as in #497 (comment), just test the from method. That should cut down on most of the copy paste work :)

@rider-yi rider-yi force-pushed the improve_numeric_types_spec branch from 5b0918b to ea36f0e Compare May 18, 2018 09:58
@rider-yi rider-yi force-pushed the improve_numeric_types_spec branch from ea36f0e to 1a12e79 Compare May 18, 2018 10:07
@rider-yi
Copy link
Contributor Author

Done

@fthomas
Copy link
Owner

fthomas commented May 18, 2018

LGTM, many thanks @rider-yi!

@fthomas fthomas merged commit 7e12673 into fthomas:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants